consolidation script #351
Merged
consolidation script #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit e8c14b2): https://fetch-docs-preview--pr351-scripts-consolidatio-uhuy3311.web.app (expires Wed, 22 May 2024 12:21:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f2de39fd4e81249941960b74fbab0a62d90d69f8 |
pbukva
reviewed
May 17, 2024
scripts/prune_genesis_codes.py
Outdated
Comment on lines
60
to
61
| original_code_hash_to_code[code["code_info"]["code_hash"]] = code | ||
| original_code_id_to_hash[code["code_id"]] = code["code_info"]["code_hash"] |
There was a problem hiding this comment.
Not that it would matter much, feel fre to ignore:
Suggested change
| original_code_hash_to_code[code["code_info"]["code_hash"]] = code | |
| original_code_id_to_hash[code["code_id"]] = code["code_info"]["code_hash"] | |
| code_hash = code["code_info"]["code_hash"] | |
| original_code_hash_to_code[code_hash] = code | |
| original_code_id_to_hash[code["code_id"]] = code_hash |
pbukva
reviewed
May 17, 2024
pbukva
reviewed
May 17, 2024
pbukva
reviewed
May 17, 2024
| print("Replacing code IDs") | ||
| # Replace old code IDs with new ones | ||
| for contract in contracts: | ||
| code_id = contract["contract_info"]["code_id"] |
There was a problem hiding this comment.
Suggested change
| code_id = contract["contract_info"]["code_id"] | |
| contract_struct = contract["contract_info"] | |
| code_id = contract_struct["code_id"] |
pbukva
reviewed
May 17, 2024
| # Convert old code ID to new one | ||
| new_code_id = new_code_hash_to_code[code_hash]["code_id"] | ||
|
|
||
| contract["contract_info"]["code_id"] = new_code_id |
There was a problem hiding this comment.
Suggested change
| contract["contract_info"]["code_id"] = new_code_id | |
| contract_struct["code_id"] = new_code_id |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.