VM intermediate representation #984
Conversation
| lhs->matrix.InlineSubtract(rhs->matrix); | ||
| Ptr<Matrix> m = AcquireMatrix(vm_, type_id_, element_type_id_, lhs_rows, rhs_columns); | ||
| // TODO(tfr): use blas | ||
| TODO_FAIL("Use BLAS TODO"); |
There was a problem hiding this comment.
Not really sure if we want TODO_FAILS right in the middle here. Does it just make sense to set a RuntimeError on the VM
There was a problem hiding this comment.
No, agreed - we should use runtime error in the VM.
There was a problem hiding this comment.
I can change this tonight, but it might be worthwhile to wait for @baykaner to land the blas functionality and just fix this properly.
| static TypeId const Float64 = 13; | ||
| static TypeId const PrimitiveMaxId = 13; | ||
| static TypeId const String = 14; | ||
| static TypeId const Address = 15; |
There was a problem hiding this comment.
Out of interest why does the Address get a static TypeId and State does not? Or am I missing something
There was a problem hiding this comment.
I suspect that it is because these are the types which has builtin literals. As such, Address should not be there in the first place since it does not have a literal. Rather, it should have been added as a module extension (unless there is a good reason why this was brought into the core of the VM).
|
|
||
| IR &IR::operator=(IR &&other) | ||
| { | ||
| if (&other != this) |
There was a problem hiding this comment.
I'm not sure you need to check this in a move assignment. Also, I'd consider making this operator noexcept.
No description provided.