Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updates on new V of name service contract #110

Merged
merged 4 commits into from
Jul 4, 2023
Merged

feat: updates on new V of name service contract #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fdf39a4
feat: uodates on new V of name service contract
Alejandro-Morales Jun 29, 2023
00000a1
fix: tests
Alejandro-Morales Jun 29, 2023
68a62ff
fix: lint
Alejandro-Morales Jun 29, 2023
afd50f3
delete get_ownership_msg
Alejandro-Morales Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/uagents/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class AgentNetwork(Enum):
USER_PREFIX = "user"
CONTRACT_ALMANAC = "fetch1h5rhtj5m6dqjmufj5m3t4mq6l7cnd8dvaxclwmrk6tfdm0gy3lmszksf0s"
CONTRACT_NAME_SERVICE = (
"fetch1yrf4xpglq02fzj50m9wn44qdq89a5vr0ufa42qa506uhwal4n79s99sp87"
"fetch1mxz8kn3l5ksaftx8a9pj9a6prpzk2uhxnqdkwuqvuh37tw80xu6qges77l"
)
REGISTRATION_FEE = 500000000000000000
REGISTRATION_DENOM = "atestfet"
Expand Down
15 changes: 0 additions & 15 deletions src/uagents/network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,15 +98,6 @@ def is_owner(self, name: str, wallet_address: str):
permission = self.query(query_msg)["permissions"]
return permission == "admin"

def _get_ownership_msg(self, name: str, wallet_address: str):
return {
"update_ownership": {
"domain": f"{name}.agent",
"owner": {"address": {"address": wallet_address}},
"permissions": "admin",
}
}

def _get_registration_msg(self, name: str, address: str):
return {
"register": {
Expand All @@ -121,14 +112,8 @@ def get_registration_tx(self, name: str, wallet_address: str, agent_address: str

transaction = Transaction()

ownership_msg = self._get_ownership_msg(name, wallet_address)
registration_msg = self._get_registration_msg(name, agent_address)

transaction.add_message(
create_cosmwasm_execute_msg(
wallet_address, CONTRACT_NAME_SERVICE, ownership_msg
)
)
transaction.add_message(
create_cosmwasm_execute_msg(
wallet_address, CONTRACT_NAME_SERVICE, registration_msg
Expand Down
22 changes: 0 additions & 22 deletions tests/test_agent_registration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,24 +48,6 @@ def test_alamanc_failed_registration(self):
"Shouldn't be registered on alamanac",
)

def test_name_service_ownership(self):
agent = Agent()
fund_agent_if_low(agent.wallet.address())

ownership_msg = agent._service_contract._get_ownership_msg(
agent.name, str(agent.wallet.address())
)

transaction = agent._service_contract.execute(ownership_msg, agent.wallet)

transaction.wait_to_complete()

is_owner = agent._service_contract.is_owner(
agent.name, str(agent.wallet.address())
)

self.assertEqual(is_owner, True, "Domain ownership failed")

def test_name_service_failed_ownership(self):
agent = Agent()

Expand Down Expand Up @@ -110,14 +92,10 @@ def test_registration(self):
)
self.assertEqual(is_owner, False)

ownership_msg = agent._service_contract._get_ownership_msg(
agent.name, str(agent.wallet.address())
)
registration_msg = agent._service_contract._get_registration_msg(
agent.name, agent.address
)

agent._service_contract.execute(ownership_msg, agent.wallet).wait_to_complete()
agent._service_contract.execute(
registration_msg, agent.wallet
).wait_to_complete()
Expand Down