Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FetchIt!] STL updates for new largeGear #51

Merged
merged 2 commits into from Mar 27, 2019

Conversation

Projects
None yet
4 participants
@moriarty
Copy link
Member

commented Mar 25, 2019

This fixes #50 in part, the stl files are done but not the dae files.

These changes correspond to fetchrobotics/fetchit#2

@RDaneelOlivav I'm not actually familiar with Blender or dae files and tried to export them but they didn't look correct. Can you update the dae files and submit a PR to this branch?

[FetchIt!] STL updates for new largeGear
This fixes #50 in part, the stl files are done but not the dae files.

These changes correspond to fetchrobotics/fetchit#2
@RDaneelOlivav

This comment has been minimized.

Copy link
Collaborator

commented Mar 25, 2019

@moriarty Ok, I'll check the new STL, compare them to see the differences and adapt the Daes if needed. Because the STLs are used for the collisions mainly to minimize the load in the physics contact simulation. Depending on how I'll change the daes ( visual meshes ) to match those changes.

@RDaneelOlivav RDaneelOlivav referenced this pull request Mar 25, 2019

Closed

Update 3D Parts #50

@moriarty

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2019

👍

@RDaneelOlivav

This comment has been minimized.

Copy link
Collaborator

commented Mar 27, 2019

Ok I commited the changes to the update-parts branch on moriarty/fetch_gazebo.
commit a866975.

I added the new versions of the dae files, with the same colors as the previous ones and rescaled them to be exactly the same scale also as the originals.

Sorry if I commited where I shouldn't have, I'm unfamiliar with projects with so many micro commits, forked versions, and branches.

Please indicate me for the next time what would have been the preferable procedure for the next time ;).

Do I have to make a pull request then of these changes now?
@moriarty

@moriarty

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2019

Looks fine. Committing on top of this branch is perfect.

Usually, I merge with squash and merge, so there aren't that many commits.

I'll merge this now, and trust that you tested it, and then run bloom-release to Indigo & Melodic.

With PR #38 I didn't squash and merge 😢

@moriarty moriarty merged commit 13d6c25 into fetchrobotics:gazebo9 Mar 27, 2019

moriarty added a commit to moriarty/fetch_gazebo that referenced this pull request Mar 28, 2019

[FetchIt!] Model updates for new largeGear (fetchrobotics#51)
* [FetchIt!] STL updates for new largeGear
  * This fixes fetchrobotics#50 in part, the stl files
  * These changes correspond to fetchrobotics/fetchit#2
* Added updated dae versions with rescaling to correct dimensions and same colours as previous versions

moriarty added a commit to moriarty/fetch_gazebo that referenced this pull request Mar 28, 2019

[FetchIt!] Model updates for new largeGear (fetchrobotics#51)
* [FetchIt!] STL updates for new largeGear
  * This fixes fetchrobotics#50 in part, the stl files
  * These changes correspond to fetchrobotics/fetchit#2
* Added updated dae versions with rescaling to correct dimensions and same colours as previous versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.