Use Set for users and groups, for better lookup performance

lib/rollout.rb

@@ -1,6 +1,7 @@
 require "rollout/version"
 require "rollout/legacy"
 require "zlib"
+require 'set'
 
 class Rollout
   class Feature
@@ -14,15 +15,15 @@ def initialize(name, string = nil, opts = {})
       if string
         raw_percentage,raw_users,raw_groups = string.split("|")
         @percentage = raw_percentage.to_i
-        @users = (raw_users || "").split(",").map(&:to_s)
-        @groups = (raw_groups || "").split(",").map(&:to_sym)
+        @users = (raw_users || "").split(",").map(&:to_s).to_set
+        @groups = (raw_groups || "").split(",").map(&:to_sym).to_set
       else
         clear
       end
     end
 
     def serialize
-      "#{@percentage}|#{@users.join(",")}|#{@groups.join(",")}"
+      "#{@percentage}|#{@users.to_a.join(",")}|#{@groups.to_a.join(",")}"
     end
 
     def add_user(user)
@@ -43,8 +44,8 @@ def remove_group(group)
     end
 
     def clear
-      @groups = []
-      @users = []
+      @groups = Set.new
+      @users = Set.new
       @percentage = 0
     end
 

spec/rollout_spec.rb

@@ -51,7 +51,7 @@
     end
 
     it "leaves the other groups active" do
-      @rollout.get(:chat).groups.should == [:fivesonly]
+      @rollout.get(:chat).groups.should == [:fivesonly].to_set
     end
   end
 
@@ -139,7 +139,7 @@
     end
 
     it "remains active for other active users" do
-      @rollout.get(:chat).users.should == %w(24)
+      @rollout.get(:chat).users.should == %w(24).to_set
     end
   end
 
@@ -291,13 +291,13 @@
 
     it "returns the feature object" do
       feature = @rollout.get(:chat)
-      feature.groups.should == [:caretakers, :greeters]
+      feature.groups.should == [:caretakers, :greeters].to_set
       feature.percentage.should == 10
-      feature.users.should == %w(42)
+      feature.users.should == %w(42).to_set
       feature.to_hash.should == {
-        :groups => [:caretakers, :greeters],
+        :groups => [:caretakers, :greeters].to_set,
         :percentage => 10,
-        :users => %w(42)
+        :users => %w(42).to_set
       }
 
       feature = @rollout.get(:signup)
@@ -320,8 +320,8 @@
       features.each do |feature|
         @rollout.get(feature).to_hash.should == {
           :percentage => 0,
-          :users => [],
-          :groups => []
+          :users => Set.new,
+          :groups => Set.new
         }
       end
     end
@@ -350,8 +350,8 @@
       @legacy.deactivate_all(:chat)
       @rollout.get(:chat).to_hash.should == {
         :percentage => 12,
-        :users => %w(24 42),
-        :groups => [:dope_people]
+        :users => %w(24 42).to_set,
+        :groups => [:dope_people].to_set
       }
       @redis.get("feature:chat").should_not be_nil
     end