Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Updated texts for Tighten Up Signup Flow #19775 #340

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Updated texts for Tighten Up Signup Flow #19775 #340

merged 1 commit into from
Mar 6, 2023

Conversation

ivanyeoh
Copy link
Contributor

@ivanyeoh ivanyeoh commented Mar 3, 2023 •
edited
Loading

nielsenramon
nielsenramon approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@nielsenramon nielsenramon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind running the command so all translations have this change please 🙏 @ivanyeoh

@ivanyeoh
Copy link
Contributor Author

ivanyeoh commented Mar 3, 2023

@nielsenramon yes sure, I was about to ask if who will translate for other languages?

@nielsenramon
Copy link
Member

@ivanyeoh For most of them we have translations already, if not, use english!

@ivanyeoh
Copy link
Contributor Author

ivanyeoh commented Mar 3, 2023

@nielsenramon because the meaning has change, so we should turn those in other languages back in english right?
e.g.

 - label: Verification Code
 + label: Enter the 6-digit code we just sent to your mobile phone.
   
 - title: Last Step
 + title: Verification Time!

@nielsenramon
Copy link
Member

because the meaning has change, so we should turn those in other languages back in english right?

Correct!

@ivanyeoh ivanyeoh force-pushed the 19775-tighten-up-signup-flow branch from 374215f to a4d46aa Compare March 3, 2023 16:24
@ivanyeoh ivanyeoh merged commit 1aba7a0 into master Mar 6, 2023
@ivanyeoh ivanyeoh deleted the 19775-tighten-up-signup-flow branch March 6, 2023 07:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nielsenramon nielsenramon nielsenramon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanyeoh @nielsenramon