-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/api/v3/ability
returns unofficial translations
#1127
Comments
It does not only happen in For example, |
I agree in general. At this time, the localized-names returned by the API are intended for display to the user and are not suitable for exact matching. Our project has no parties other than Japanese and English (both US & UK). |
Updated using Splatoon3.ink locale data
All translations regarding abilities have been updated with the data provided by Splatoon3.ink. |
Thanks for the fix! I'll make some minor changes and upload a few games to test using |
With the addition of the reporting field for gear in stat.ink, s3si.ts was the first to implement the reporting of gear.
Since the
ability
returned from the official API only hasname
, aname
->key
mapping is needed.I thought that the api
/api/v3/ability?full=1
mentioned in theinfo
of theprimary_ability
field would have the same name as the official one, but it doesn't.For example, in
zh-CN
,sub_power_up
is officially shown as提升次要武器性能
, while the API in stat.ink shows副武器增强
.Fortunately, there is an official API that lists all
ability
(myOutfitCommonDataFilteringConditionQuery). I wrote a script to get the names of allability
: https://github.com/spacemeowx2/s3si.ts/blob/main/scripts/generate-gear-map.tsAnd here is the result: https://gist.github.com/spacemeowx2/56377320c219c30139887ec71d9687e6
I think it would be better if
/api/v3/ability?full=1
returned the official name。The text was updated successfully, but these errors were encountered: