Issues with the for loop and the unset statement

[inspektorsowa]

Hi there,
it seems that the library doesn't manage with the "for" loop and the "unset" statement.

This is my PHP code:

<?php
namespace Brainusers;
class ZephirTest {
    static public function hello() {
        $obj = array();
        for ($i=0; $i<1000; $i++) {
            $obj[] = new ZephirTest();
        }
        unset($obj);
    }
}

Output is:

namespace Brainusers;

class ZephirTest
{
    public static function hello() -> void
    {
        var obj, i;


        let obj =  [];
        for let i = 0; i < 1000; let i++ {
            let obj[] = new ZephirTest();
        }
        unset(obj);

    }

}

Trying to build:

$ zephir build
Zephir\ParseException: Syntax error in /php2zephir/brainusers/brainusers/zephirtest.zep on line 11

            for let i = 0; i < 1000; let i++ {
    --------------^

After changed to for i in range(0,1000) there is a problem with unset:

$ zephir build
Zephir\CompilerException: Cannot use expression type: variable in "unset" in /php2zephir/brainusers/brainusers/zephirtest.zep on line 14

            unset(obj);
    -----------------^

[fezfez]

Hi !

I fix the for loop.

For the unset statement, the translation is correct maybe open a ticket at https://github.com/phalcon/zephir/issues/

Thanks for the report !

[inspektorsowa]

Thank you for a such quick reply.

The unset() in PHP is more like a language expression than a function.

unset($a);

However in Zephir to unset a variable you have to use it without brackets (like an echo):

unset a;

So maybe you can change the conversion unset($a) to unset a?

[fezfez]

I cant test Zephir compilation right now, so i trust you and i change the unset translation.
Can you test with master ?

Thanks !

[inspektorsowa]

Now the unset works only for the array elements, but not for variables. I will notify the Zephir devs. Thanks.

[fezfez]

Thanks !