Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ORSet tests #91

Merged
merged 5 commits into from
Jul 8, 2019
Merged

Add ORSet tests #91

merged 5 commits into from
Jul 8, 2019

Conversation

cblp
Copy link
Member

@cblp cblp commented Jul 8, 2019

This change is Reviewable

Copy link
Member Author

@cblp cblp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 13 files at r1.
Reviewable status: all files reviewed, 9 unresolved discussions


ron-rdt/lib/RON/Data/ORSet.hs, line 12 at r2 (raw file):

module RON.Data.ORSet
    ( ORSet (..)
    , ORSetItem (..)

changelog


ron-rdt/lib/RON/Data/ORSet.hs, line 17 at r2 (raw file):

    , addValue
    , findAnyAlive
    , findAnyAlive'

changelog


ron-rdt/lib/RON/Data/ORSet.hs, line 20 at r2 (raw file):

    , removeRef
    , removeValue
    , zoom

changelog


ron-rdt/lib/RON/Data/ORSet.hs, line 175 at r2 (raw file):

    deriving (Show)

zoom

doc


ron-rdt/lib/RON/Data/ORSet.hs, line 181 at r2 (raw file):

    lift $ runReaderT innerModifier value

findAnyAlive

doc


ron-rdt/lib/RON/Data/ORSet.hs, line 194 at r2 (raw file):

            _ -> throwErrorText "item payload is not an object ref"

findAnyAlive'

doc


ron-schema/lib/RON/Schema/TH.hs, line 94 at r2 (raw file):

mkAlias :: Alias Resolved -> TH.DecsQ
mkAlias Alias{name, target} =
    (:[]) <$> TH.tySynD (mkNameT name) [] (mkGuideType target)

?


ron-test/ORSet.hs, line 84 at r2 (raw file):

--     -- serialize object after modification
--     prep ex4expect === prep (snd $ serializeObject state4)

?


ron-test/lib/LwwStruct/Types.hs, line 79 at r2 (raw file):

deriving instance Show Struct51

_check_Alias69 :: Alias69 :~: ORSet Struct51

?

Copy link
Member Author

@cblp cblp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 8 unresolved discussions


ron-rdt/lib/RON/Data/ORSet.hs, line 172 at r3 (raw file):

-- | Reference to an item inside an 'ORSet'.
data ORSetItem a = ORSetItem{key :: UUID, value :: Object a}

Non-objects don't have value object

Copy link
Member Author

@cblp cblp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4.
Reviewable status: all files reviewed, 5 unresolved discussions

Copy link
Member Author

@cblp cblp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5.
Reviewable status: all files reviewed, 4 unresolved discussions

Copy link
Member Author

@cblp cblp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r6.
Reviewable status: all files reviewed, 3 unresolved discussions

Copy link
Member Author

@cblp cblp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r7.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@cblp cblp merged commit 3e49c9d into master Jul 8, 2019
@cblp cblp deleted the orset-more branch July 8, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant