Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Animals #326

Merged
merged 3 commits into from
Jun 27, 2017
Merged

Add Animals #326

merged 3 commits into from
Jun 27, 2017

Conversation

ni3t
Copy link
Contributor

@ni3t ni3t commented Jun 15, 2017

Add a list of animals that can be pulled with FFaker::Animal.common_name, future updates could include genus/species, name of young (cub, pup, etc)

def common_name
fetch_sample(COMMON_NAMES)
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected.

@@ -0,0 +1,13 @@
# encoding: utf-8

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing magic comment # frozen_string_literal: true.

assert_include @tester::COMMON_NAMES, @tester.common_name
end
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 trailing blank lines detected.

@@ -0,0 +1,18 @@
# encoding: utf-8

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing magic comment # frozen_string_literal: true.

@marocchino marocchino merged commit b251a6e into ffaker:master Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants