Test with github action & ruby 3 #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marocchino
force-pushed
the
change-travis-to-action
branch
2 times, most recently
from
1fab3a8
to
6a6f426
Compare
marocchino
force-pushed
the
change-travis-to-action
branch
from
6a6f426
to
0ae2b67
Compare
marocchino
force-pushed
the
change-travis-to-action
branch
from
0ae2b67
to
c99f6c7
Compare
marocchino
commented
Jan 29, 2021
| @@ -42,7 +42,7 @@ def check_format!(format) | |||
| def download_file(url) | |||
| file = Tempfile.new('ffaker_image') | |||
| file.binmode | |||
| file << Kernel.open(url).read | |||
| file << URI.open(url).read | |||
There was a problem hiding this comment.
|
Hey mate... All these changes are looking great! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.