Resolve RuboCop offenses #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplicate value from RuboCop config.
There were RuboCop offenses, and I think keyword approaches is better.
I don't know a way better, the whole approach is not the best.
Resolve these issues later.
Resolve new offenses.
AlexWayfer
commented
Aug 23, 2023
| @@ -87,7 +87,7 @@ | |||
| * [FFaker::IdentificationESCO](#ffakeridentificationesco) | |||
| * [FFaker::IdentificationIN](#ffakeridentificationin) | |||
| * [FFaker::IdentificationIT](#ffakeridentificationit) | |||
| * [FFaker::IdentificationKr](#ffakeridentificationkr) | |||
| * [FFaker::IdentificationKR](#ffakeridentificationkr) | |||
There was a problem hiding this comment.
Breaking change. I think it was an error.
| autoload_abbreviations.fetch(part) { part.capitalize } | ||
| end.join | ||
| autoload constant_name, file_name | ||
| end |
There was a problem hiding this comment.
More automatic and short system.
| $warnings << msg if $warnings | ||
| return unless Kernel.instance_variable_get(:@ffaker_warnings) | ||
|
|
||
| Kernel.instance_variable_set(:@ffaker_warnings, Kernel.instance_variable_get(:@ffaker_warnings) << msg) |
There was a problem hiding this comment.
Not sure about this, but I don't respect such Kernel#warn overwrite approach at all.
| when 5, 7 | ||
| "#{first_name} #{prefix} #{last_name}" | ||
| else | ||
| "#{first_name} #{last_name}" |
There was a problem hiding this comment.
Strange case. Can we simplify this?
marocchino
reviewed
Aug 24, 2023
marocchino
reviewed
Aug 24, 2023
Also turn them into mask by locale.
Leave keyword arguments, add deprecation warning for positional.
marocchino
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add RuboCop GitHub action.
Please note
.rubocop_todo.ymlconfig and changes to arguments.