Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second fastd instance for backbone traffic #200

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

TobleMiner
Copy link
Member

No description provided.

@sargon
Copy link
Contributor

sargon commented May 2, 2017

I am going to pull this request, but I like to see this second fastd instance optional in a later PR. Maybe by making the additional arguments to the mesh type optional, and so the second instance.

@rubo77
Copy link
Contributor

rubo77 commented May 2, 2017

Please check #128 which is another atempt by @ohrensessel

@sargon
Copy link
Contributor

sargon commented May 3, 2017

Didn't remember that one. I think this PR is more up time than #128. But the old one introduce other features we currently have not. Namely the cypher methods, but that should be done in another PR.

Let us bring this one in. I have closed the old one.

@TobleMiner TobleMiner requested review from sargon and rubo77 May 4, 2017 22:41
@TobleMiner
Copy link
Member Author

Anyone tested my changes yet? I'd like someone to approve it before merging

@rubo77 rubo77 force-pushed the master branch 2 times, most recently from 70b4764 to 6d8bf60 Compare May 29, 2017 20:47
Copy link
Contributor

@sargon sargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me except for the batman_code parameter.
I haven't done any test runs, but from experience this should run fine.

@@ -94,6 +104,22 @@
ip_prefixlen => $mesh_ipv6_prefixlen;
}

if $fastd_igw_enable {
Class['ffnord::ntp'] -> ffnord::fastd { "fastd_igw_${mesh_code}":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not entirely obvious why this should be applied after the ntp service is setup.

@@ -66,6 +75,7 @@
} ->
ffnord::fastd { "fastd_${mesh_code}":
mesh_code => $mesh_code,
batman_code => $mesh_code,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need an extra parameter batman_code, when it is the same as mesh_code, in all applied situations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants