Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOP all playing sounds #42

Closed
noVaSon opened this issue Apr 27, 2018 · 2 comments
Closed

STOP all playing sounds #42

noVaSon opened this issue Apr 27, 2018 · 2 comments
Assignees
Labels

Comments

@noVaSon
Copy link
Collaborator

noVaSon commented Apr 27, 2018

Missing feature:

Make all sound stop playing when clicking on empty map.
This is important, as when using play on hover, many sounds will play at once and one needs a lot of patience, when some of them are longer than expected.

This was referenced Apr 27, 2018
@noVaSon noVaSon added the bug label May 2, 2018
@ffont
Copy link
Owner

ffont commented May 2, 2018

In #45 we introduced a first implementation of a "stop all sounds" feature triggered when clicking in an empty space in the map. Nevertheless the implementation seems to be a bit buggy. Won't close this issue for now as it could still be improved.

@noVaSon
Copy link
Collaborator Author

noVaSon commented May 6, 2018

Note to myself:
here are some hints that could help solving the inconsistent behaviour of actually not stopping all sounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants