Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds stop all sounds playing #45

Merged
merged 3 commits into from May 2, 2018
Merged

Adds stop all sounds playing #45

merged 3 commits into from May 2, 2018

Conversation

noVaSon
Copy link
Collaborator

@noVaSon noVaSon commented Apr 27, 2018

I encountered this annoying issue #42 when using playOnHover.
Longer Sounds would only be stoppable by clicking one playing sound after the other.

Now it is synchonized with deselectAllSounds when clicking the empty map.

Unfortunately, when exthausively using the playOnHover feature some state changes seem to be so slow, that not all sounds will reliably stop.
But the majority of them will, so this is a small improvement.

@ffont
Copy link
Owner

ffont commented May 2, 2018

I don't seem to be able to get this to work. Should all sounds stop playing when I click in an empty point in the map?

@noVaSon
Copy link
Collaborator Author

noVaSon commented May 2, 2018

This is true!
I must have accidentally excluded the MapContainer.jsx from the commit!
Should work now.

@ffont
Copy link
Owner

ffont commented May 2, 2018

Yeah now it works, although as you mention in the comment it is still a bit buggy. I'll merge that but I won't close issue #42. Will add a comment about the buggy behavior that should be fixed at some point.

@ffont
Copy link
Owner

ffont commented May 2, 2018

After merging #39 this branch has now conflicts with master. @noVaSon you should merge master to this branch and resolve the conflicts, then I'll merge.

@ffont ffont merged commit 7e2f70c into ffont:master May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants