Adds stop all sounds playing #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ouble navbar search logo
…bootstrap-table-next > TODO: keep one - should be cleaned later
…ways shows up - some additional cosmetic
…site, requires user to log in twice
…into soundlist # Conflicts: # README.md
…ch tab, only descending
…way (nesessary to show some buttons)
…into soundlist EMPTY COMMIT # Conflicts: # .gitignore # README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered this annoying issue #42 when using playOnHover.
Longer Sounds would only be stoppable by clicking one playing sound after the other.
Now it is synchonized with deselectAllSounds when clicking the empty map.
Unfortunately, when exthausively using the playOnHover feature some state changes seem to be so slow, that not all sounds will reliably stop.
But the majority of them will, so this is a small improvement.