libavformat/matroskadec: set fixed duration for subtitles #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
enen92
force-pushed
the
ass_mkv_fixed_subs
branch
2 times, most recently
from
b35adad
to
3752b85
Compare
|
There is an issue in commit 3752b85: |
enen92
force-pushed
the
ass_mkv_fixed_subs
branch
2 times, most recently
from
30cd632
to
76ed24e
Compare
The matroska specification states the start time and duration of subtitle entries are encoded in the block TimeStamp and BlockDuration. Furthermore, for all subtitle formats except S_HDMV/PGS the BlockDuration must always be defined and have an absolute value even if it is simply 0. ffmpeg assumes that a duration of 0 means the duration is still unknown and tries to adjust based on the next packet pts. This is wrong for all formats except S_HDMV/PGS. Since changing the semantics of duration 0 is not an option (touches too many parts of the code) this change introduces AV_PKT_FLAG_FIXED_DURATION flag which decoders might use to flag the duration of a given packet should not be changed. Signed-off-by: Miguel Borges de Freitas <enen92@kodi.tv>
enen92
force-pushed
the
ass_mkv_fixed_subs
branch
from
76ed24e
to
5985bf7
Compare
Updates some of the test reference data to include the new AV_PKT_FLAG_FIXED_DURATION (this is the case for most matroska subtitles) Signed-off-by: Miguel Borges de Freitas <enen92@kodi.tv>
|
/submit |
|
Error: User enen92 is not yet permitted to use the FFmpeg CodeBot |
|
/approve |
|
/allow |
|
User enen92 is now allowed to use the FFmpeg Code Bot. WARNING: enen92 has no public email address set on GitHub |
@tmm1 LOL, you got me confused myself for a minute - it's allow, not approve :-) |
|
/submit |
|
Submitted as pull.48.ffstaging.FFmpeg.1673365328.ffmpegagent@gmail.com To fetch this version into To fetch this version to local tag |
|
On the FFmpeg mailing list, Miguel Borges de Freitas wrote (reply to this): |
|
User |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The matroska specification states the start time and duration of
subtitle entries are encoded in the block TimeStamp
and BlockDuration. Furthermore, for all subtitle formats except
S_HDMV/PGS the BlockDuration must always be defined and have an absolute
value even if it is simply 0. ffmpeg assumes that a duration of 0 means
the duration is still unknown and tries to adjust based on the next packet
pts. This is wrong for all formats except S_HDMV/PGS.
Since changing the semantics of duration 0 is not an option (touches too
many parts of the code) this change introduces AV_PKT_FLAG_FIXED_DURATION flag which
decoders might use to flag the duration of a given packet should not be
changed.
Signed-off-by: Miguel Borges de Freitas enen92@kodi.tv
This is my attempt at fixing https://trac.ffmpeg.org/ticket/10135
Initially reported to Kodi in xbmc/xbmc#21625
cc: Miguel Borges de Freitas enen92@kodi.tv