Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/19 integrate add member as admin #37

Merged
merged 6 commits into from
Sep 29, 2021
Merged

Feature/19 integrate add member as admin #37

merged 6 commits into from
Sep 29, 2021

Conversation

arthurarp
Copy link
Collaborator

Closes #27

arthurarp and others added 4 commits September 27, 2021 18:57
@arthurarp @markinlimac
[#27] feat - Add new endpoints
4efda1f 
Co-authored-by: Marco Antonio <markinlimac@gmail.com>
Signed-off-by: Arthur <arthurarp@hotmail.com>
@arthurarp @guilherme1guy @markinlimac
[#27] feat - Change endpoints to correct order
755e590 
Co-authored-by: Guilherme Guy <guilhermeguy349@gmail.com>
Co-authored-by: Marco Antonio <markinlimac@gmail.com>
Signed-off-by: Arthur <arthurarp@hotmail.com>
@arthurarp @guilherme1guy @markinlimac
[#27] fix - Change the message handler of removeUser endpoint to matc…
71a6c5c 
…h with the service's handler

Co-authored-by: Guilherme Guy <guilhermeguy349@gmail.com>
Co-authored-by: Marco Antonio <markinlimac@gmail.com>
Signed-off-by: Arthur <arthurarp@hotmail.com>
@arthurarp @guilherme1guy @markinlimac
[#27] fix - Change Param decorator to Query decorator on getUsers and…
6762008 
… getUsersAdmin endpoints

Co-authored-by: Guilherme Guy <guilhermeguy349@gmail.com>
Co-authored-by: Marco Antonio <markinlimac@gmail.com>
Signed-off-by: Arthur <arthurarp@hotmail.com>
@arthurarp arthurarp requested review from a team, Mikhaelle, leossb36 and markinlimac and removed request for a team September 29, 2021 04:36
arthurarp and others added 2 commits September 29, 2021 01:57
@arthurarp @markinlimac
[#27] test - Add unit tests on created userAdmin endpoints
d730308 
Co-authored-by: Marco Antonio <markinlimac@gmail.com>
Signed-off-by: Arthur <arthurarp@hotmail.com>
@arthurarp @markinlimac
[#27] refactor - Using userRelation to userAdmin and remove userAdmin…
983c8c3 
…Relation

Co-authored-by: Marco Antonio <markinlimac@gmail.com>
Signed-off-by: Arthur <arthurarp@hotmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

markinlimac
markinlimac approved these changes Sep 29, 2021
View reviewed changes
Copy link
Collaborator

@markinlimac markinlimac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tudo certo!

@markinlimac markinlimac merged commit 0e07eb7 into develop Sep 29, 2021
guilherme1guy added a commit that referenced this pull request Oct 12, 2021
@guilherme1guy @leossb36
[#37] reaft - Refactor DTOs for update point and area
b835673 
Co-authored-by: Leonardo Barreiros <leossb36@gmail.com>
guilherme1guy added a commit that referenced this pull request Oct 15, 2021
@guilherme1guy
Merge pull request #45 from fga-eps-mds/feature/44-improve-refactor-dto
8bb5b9f 
[#37] reaft - Refactor DTOs for update point and area
@markinlimac markinlimac deleted the feature/19-integrate-add-member-as-admin branch November 6, 2021 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markinlimac markinlimac markinlimac approved these changes

@Mikhaelle Mikhaelle Awaiting requested review from Mikhaelle

@leossb36 leossb36 Awaiting requested review from leossb36

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[US19] Integrar gateway com serviço de Comunidades e Usuários para definição de membro administrador
2 participants
@arthurarp @markinlimac