Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom options if they exist #16

Merged
merged 4 commits into from
Sep 9, 2013

Conversation

stepheneb
Copy link
Collaborator

If a custom .jshintrc exists use options defined there instead of default options.

Look in the following places and if .jshintrc exists
return those options.

  1. env.TM_DIRECTORY: the directory of the current textmate file
  2. env.TM_PROJECT_DIRECTORY: the directory of the current text mate project
  3. env.HOME: users home dir

Otherwise return default options.

@stepheneb
Copy link
Collaborator Author

fyi: this pull request is based on the correct-path-to-hosted-jshint branch in #14

Recent JSHint releases need the production node modules
listed in the jshint package.json file.
If autoupdate downloads jshint.js because it is out-of-date
it now also updates package.json and runs:
  npm install --production
If a custom .jshintrc exists use options defined there
instead of default options.

Look in the following places and if .jshintrc exists
return those options.

env.TM_DIRECTORY
- the directory of the current textmate file

env.TM_PROJECT_DIRECTORY
- the directory of the current text mate project

env.HOME
- users home dir

Otherwise return default options.
@stepheneb
Copy link
Collaborator Author

Now this is based on include-jshint-npm-production-dependencies in #17

@stepheneb stepheneb mentioned this pull request Sep 7, 2013
@stepheneb
Copy link
Collaborator Author

This now also removes "es5": true from default options to prevent display of this info message the latest jshin generates: ES5 option is now set per default

See: ES5 option is now set per default

@fgnass
Copy link
Owner

fgnass commented Sep 9, 2013

Thank for your contributions! Since I no longer use TextMate I added you as collaborator to this projects so that you merge the PRs yourself. Again, thanks a lot for your work!

@stepheneb
Copy link
Collaborator Author

Thanks Felix,

Are you using SublimeText like most of the other people I work with?

Since I've found the need to rebase some of these pull requests I'll keep using them for a few more days before merging.

@fgnass
Copy link
Owner

fgnass commented Sep 9, 2013

Yes, I'm currently using SublimeText 2 while I wait for Brackets to get mature enough to be usable ;)

@stepheneb stepheneb merged commit 19e1cc7 into fgnass:master Sep 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants