Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unbind error #149

Merged
merged 1 commit into from
Mar 19, 2023
Merged

fix unbind error #149

merged 1 commit into from
Mar 19, 2023

Conversation

lrgfilipe
Copy link
Contributor

When unbind function is called and the key K (ShortKey.encodeKey(value[key])) does not exist in mapFunctions this console error appears:
TypeError: Cannot read properties of undefined (reading 'el') at unbind

Could you please review the changes and merge it if possible ?

Thanks

Copy link
Owner

@fgr-araujo fgr-araujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fgr-araujo fgr-araujo merged commit 2384510 into fgr-araujo:master Mar 19, 2023
@lrgfilipe
Copy link
Contributor Author

Hi,
Thanks for merging it.
Do you have any idea when it is going to be released ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants