Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Launchy using ENV variable instead of completely redefining deliver! method. #73

Merged
merged 1 commit into from
Jan 14, 2018

Conversation

nashby
Copy link
Contributor

@nashby nashby commented Jan 2, 2018

Since a new version of letter_opener is released and there's a change in LetterOpener::Message.rendered_messages method (now we send location using options param) letter_opener_web is broken when letter_opener_web as delivery method is used (sorry about that).

There's a bug report about it here ryanb/letter_opener#147. I think it makes sense to disable Launchy using LAUNCHY_DRY_RUN env variable (https://github.com/copiousfreetime/launchy/blob/master/lib/launchy.rb#L15) to avoid future issues with compatibilities with letter_opener gem. What do you think?

@GarrisonD
Copy link

@pseudomuto are you going to merge this PR soon?

I think plenty of developers who use latests versions of letter_opener_web and letter_opener need it.

@pseudomuto
Copy link
Contributor

My apologies. I wasn't pinged here so I didn't see it. 👀

Copy link
Contributor

@pseudomuto pseudomuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for the fix man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants