Disable Launchy and ignore executable command detection #75
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iguchi1124
approved these changes
Jan 16, 2018
tricknotes
force-pushed
the
ignore-launcy-command-not-found
branch
2 times, most recently
from
ef8dfc6
to
2a00b4b
Compare
|
@pseudomuto ping |
pseudomuto
approved these changes
Jan 28, 2018
There was a problem hiding this comment.
Hey man, thanks for the PR! I have a small nitpick about a typo, but otherwise this LGTM 👍
@iguchi1124 thanks for pinging me
| super | ||
| ENV['LAUNCHY_DRY_RUN'] = 'false' | ||
| rescue Launchy::CommandNotFoundError # rubocop:disable HandleExceptions | ||
| # Ignore for non-executable Launchy envirofment. |
There was a problem hiding this comment.
s/envirofment/environment/
There was a problem hiding this comment.
Oops :<
I fixed and rebased as 661ef92 .
When Launchy runs dry run mode, its runner will detect executable command. Ref: https://github.com/copiousfreetime/launchy/blob/v2.4.3/lib/launchy/detect/runner.rb#L58 It makes sense for Launchy. So letter_opener_web should avoid this error.
tricknotes
force-pushed
the
ignore-launcy-command-not-found
branch
from
2a00b4b
to
661ef92
Compare
|
Thanks for your merge, @pseudomuto ! Could you release a new version? |
|
Just released v1.3.3 |
|
Great thanks ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Launchy runs dry run mode, its runner will detect executable command.
Ref: https://github.com/copiousfreetime/launchy/blob/v2.4.3/lib/launchy/detect/runner.rb#L58
It makes sense for Launchy. So letter_opener_web should be avoid this error.
This PR follows up #73.