This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
Add sudo for redir #259
Merged
Add sudo for redir #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guerremdq thanks! I'd love to bring this in but would you be able to fix the specs? :-) I also think it would be a good idea to use sudo only for ports < 1024 and warn the user about that to be consistent with Vagrant's behavior |
|
I'm working on this fixes. I will let you know when i finish. |
|
I add the check to use sudo only if the port is < 1024. But i think that is more complicate to check if the port is < 1024 when you make the kill of redir. |
|
Oh, you can get the port from the pidfile name :-) |
fgrehm
added a commit
that referenced
this pull request
May 4, 2014
fgrehm
added a commit
that referenced
this pull request
May 4, 2014
|
Thanks, If you want i can fix it and add the tests. |
|
Don't worry, I've fixed it and pushed already 😃 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add sudo for the redir_cmd, this is necessary when you try to use the 80 port on the box.