This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
Make MAC address regex check case insensitive #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex check for the container MAC address presence in the dnsmasq leases file is case sensitive. Dnsmasq outputs uppercase addresses in the leases file. As MAC addresses are generally considered case insensitive, it makes sense to relax the regular expression check to allow for this.
fgrehm
added a commit
that referenced
this pull request
May 13, 2014
Make MAC address regex check case insensitive
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex check for the container MAC address presence in the
dnsmasq leases file is case sensitive. Dnsmasq outputs lowercase
addresses in the leases file.
As MAC addresses are generally considered case insensitive, it
makes sense to relax the regular expression check to allow for this.