Increase the re-tries amount #426
Conversation
|
btw, from what I understand, vagrant-lxc should fallback to use "FetchIpFromDnsmasqLeases" which it seems not to be properly working. I still get an "There was an error executing lxc-attach" exception. |
|
Vagrant-lxc seems to try to the dns masq leases and it all seems fine but the exception is still thrown. |
|
Yeah I recall that section of code being kind of messy. |
|
Sure, just give me a hint how |
|
Oh yeah, you guys are looking at code that has been hardly changed since 2013 😄 @fonsecas72 you should probably make that a config option on https://github.com/fgrehm/vagrant-lxc/blob/master/lib/vagrant-lxc/config.rb. @ccope WDYT? |
| def initialize | ||
| @customizations = [] | ||
| @backingstore = UNSET_VALUE | ||
| @backingstore_options = [] | ||
| @sudo_wrapper = UNSET_VALUE | ||
| @container_name = UNSET_VALUE | ||
| @fetch_ip_tries = 10 |
There was a problem hiding this comment.
Close, I think the default values go in the finalize! method.
|
@ccope there you go, thanks! |
|
@ccope do you know when will you release it? |
|
I don't have access to the rubygems account. @globin would you guys be up for cutting a release? |
|
@ccope please shoot me your rubygems email either as a comment here or to the email on my GH profile and I'll get that sorted out 🍻 |
|
@fgrehm I'm sorry but can I do something for this to be released? My rubygems username is fonsecas72 (I could not find your email). |
|
Sorry, I got swamped with work stuff the last two weeks. I'll figure out how to do the release tonight. |
|
friendly reminder @ccope |
|
Done! @fonsecas72 |
It seems that on slower systems, 30 seconds is not enough to properly get the ip address.