Skip to content
This repository has been archived by the owner on Apr 23, 2023. It is now read-only.

Run CI for PHP 8.0/8.1 #89

Merged
merged 6 commits into from
Dec 11, 2021
Merged

Run CI for PHP 8.0/8.1 #89

merged 6 commits into from
Dec 11, 2021

Conversation

TimWolla
Copy link
Contributor

Hi @fgrosse! As discussed in #88 I've handled the updates for the CI. In each commit I did just the minimally necessary change to keep the CI green. For this reason I only dropped PHP 7.0 for now. But feel free to also drop 7.1 yourself afterwards!

I've cherry-picked the changes from #85 to properly attribute the original author.

PHPUnit 9.0 could not yet be added, because that breaks the tests even with PHP 7.4.

@TimWolla
Copy link
Contributor Author

btw: I believe an increase in the minor version (i.e. 2.4.0) would be sufficient here, because dropping PHP versions is not actually a breaking change. Users that still need to rely on PHP 7.0 just won't get the new version. It won't accidentally break their code.

@TimWolla
Copy link
Contributor Author

PHPUnit 9.0 could not yet be added, because that breaks the tests even with PHP 7.4.

This is likely due to this warning:

The @ExpectedException, @expectedExceptionCode, @expectedExceptionMessage, and @expectedExceptionMessageRegExp annotations are deprecated. They will be removed in PHPUnit 9. Refactor your test to use expectException(), expectExceptionCode(), expectExceptionMessage(), or expectExceptionMessageMatches() instead.

I'll handle this in a follow-up PR (dropping PHP 7.1 support) to keep it easy to review in small chunks 😃

@fgrosse
Copy link
Owner

fgrosse commented Dec 11, 2021

Great job, thanks!

I'm gonna merge and release this as v2.4.0 like you suggested.

@fgrosse fgrosse merged commit 2bb74f1 into fgrosse:master Dec 11, 2021
@TimWolla TimWolla deleted the ci branch December 11, 2021 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants