refactor(bacnet-client): implement options parameter to client functions

BREAKING CHANGE: various function parameters changed. Adapt according latest documentation.
fh1ch · Dec 24, 2017 · 12f27ef · 12f27ef
1 parent 28d4844
commit 12f27ef
Show file tree

Hide file tree

Showing 6 changed files with 237 additions and 121 deletions.
diff --git a/lib/bacnet-client.js b/lib/bacnet-client.js
diff --git a/lib/bacnet-enum.js b/lib/bacnet-enum.js
@@ -643,6 +643,10 @@ module.exports.BacnetReliability = {
   RELIABILITY_TRIPPED: 13
 };
 
+/**
+ * @readonly
+ * @enum {BacnetMaxSegments}
+ */
 module.exports.BacnetMaxSegments = {
   MAX_SEG0: 0,
   MAX_SEG2: 0x10,
@@ -654,6 +658,10 @@ module.exports.BacnetMaxSegments = {
   MAX_SEG65: 0x70
 };
 
+/**
+ * @readonly
+ * @enum {BacnetMaxAdpu}
+ */
 module.exports.BacnetMaxAdpu = {
   MAX_APDU50: 0,
   MAX_APDU128: 1,

diff --git a/test/integration/device-communication-control.spec.js b/test/integration/device-communication-control.spec.js
@@ -4,7 +4,7 @@ var utils = require('./utils');
 describe('bacstack - deviceCommunicationControl integration', function() {
   it('should return a timeout error if no device is available', function(next) {
     var client = new utils.bacnetClient({adpuTimeout: 200});
-    client.deviceCommunicationControl('127.0.0.1', 60, 1, 'Test1234',  function(err, value) {
+    client.deviceCommunicationControl('127.0.0.1', 60, 1, {password: 'Test1234'},  function(err, value) {
       expect(err.message).to.eql('ERR_TIMEOUT');
       expect(value).to.eql(undefined);
       client.close();

diff --git a/test/integration/read-property.spec.js b/test/integration/read-property.spec.js
@@ -4,7 +4,7 @@ var utils = require('./utils');
 describe('bacstack - readProperty integration', function() {
   it('should return a timeout error if no device is available', function(next) {
     var client = new utils.bacnetClient({adpuTimeout: 200});
-    client.readProperty('127.0.0.1', 8, 44301, 28, null, function(err, value) {
+    client.readProperty('127.0.0.1', 8, 44301, 28, function(err, value) {
       expect(err.message).to.eql('ERR_TIMEOUT');
       expect(value).to.eql(undefined);
       client.close();

diff --git a/test/integration/reinitialize-sevice.spec.js b/test/integration/reinitialize-sevice.spec.js
@@ -4,7 +4,7 @@ var utils = require('./utils');
 describe('bacstack - reinitializeDevice integration', function() {
   it('should return a timeout error if no device is available', function(next) {
     var client = new utils.bacnetClient({adpuTimeout: 200});
-    client.reinitializeDevice('127.0.0.1', 1, 'Test1234',  function(err, value) {
+    client.reinitializeDevice('127.0.0.1', 1, {password: 'Test1234'},  function(err, value) {
       expect(err.message).to.eql('ERR_TIMEOUT');
       expect(value).to.eql(undefined);
       client.close();

diff --git a/test/integration/write-property.spec.js b/test/integration/write-property.spec.js
@@ -4,7 +4,7 @@ var utils = require('./utils');
 describe('bacstack - writeProperty integration', function() {
   it('should return a timeout error if no device is available', function(next) {
     var client = new utils.bacnetClient({adpuTimeout: 200});
-    client.writeProperty('127.0.0.1', 8, 44301, 28, 12, [{type: 4, value: 100}], function(err, value) {
+    client.writeProperty('127.0.0.1', 8, 44301, 28, [{type: 4, value: 100}], function(err, value) {
       expect(err.message).to.eql('ERR_TIMEOUT');
       expect(value).to.eql(undefined);
       client.close();