-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Improve lodepng" dc1033a makes ECT much slower #4
Comments
Thank you for the report, can you send me an example picture? |
Cannot distribute test images. But can reproduce on this 4000x2000 gradient from Photoshop to a lesser extent: https://i.imgur.com/dktlptr.png 83a1fd9 -9 speed: 150 seconds 83a1fd9 -5 speed: 62 seconds Both commits create identical output. |
great improvement for 0.3: it's faster and it compresses better, and it's even better without dc1033a. this commit make ect slower (for same results) according to my tests. |
I tested the image. The commit does indeed decrease performance, but only on windows. On OS X, the performance stays the same(tested with gcc and clang). The error appears to be in the new lodepng_inflate function, which used to call lodepng's inflate implementation, but now uses zlib's. |
Should have the old performance now as the patch is partially reversed. |
for ect -3 : v0.3 without dc1033a v0.3 with e438159 for ect -7 : v0.3 without dc1033a v0.3 with e438159 |
Testing compiles of dc1033a vs 83a1fd9 shows that at least for me dc1033a is much slower.
Using GCC 5.3.0 msys2 to compile on Windows 7 x64 with "-flto -march=native -mtune=native" added to C(XX)FLAGS on an AVX2-capable Intel CPU, the resulting binary of dc1033a is approx 2-3x slower than 83a1fd9. I am testing on large (7MB, ~8 megapixel) 24-bit PNGs.
Using commandline
ect -9 --strict --mt-deflate=12 image.png
. Hopefully can be fixed.Thanks for making ECT.
The text was updated successfully, but these errors were encountered: