Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file-multithreaded execution #69

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Conversation

TellowKrinkle
Copy link
Contributor

Appears to run without issue when tested with PNGs and JPEGs with Thread Sanitizer enabled
Helps with #53
Use --mt-file or --mt-file=i to enable

@fhanau
Copy link
Owner

fhanau commented Nov 30, 2018

Thank you. I actually also implemented file-based multithreading some time ago, but did not clean it up and merge it. I'll look at your changes and will probably merge them as they look more elegant than my approach.

@andrews05
Copy link
Contributor

Does this also work when creating/recompressing zip archives?

@TellowKrinkle
Copy link
Contributor Author

It looks like zip file compression is handled separately and I didn't modify it, so it won't work for zip archives

@fhanau fhanau merged commit 4b3232c into fhanau:master Mar 22, 2019
@fhanau
Copy link
Owner

fhanau commented Mar 22, 2019

Thanks, this approach turned out to be more elegant than the file-based multithreading I was working on.

@TellowKrinkle TellowKrinkle deleted the Multithread branch March 22, 2019 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants