fixed crash when using older themes with missing keys, fixes Bug:#426490

fheinle · Sep 21, 2009 · f599e71 · f599e71
2 parents bd32b09 + 860971f
commit f599e71
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -12,6 +12,7 @@ User visible changes
 Bugfixes
 --------
 * fixed crash on startup if more than 1 language in $LANGUAGE (LP:#367990, #365477)
+* fixed crash when using older themes with missing keys (LP:#426490)
 
 Noteable background changes
 ---------------------------

diff --git a/PyRoom/gui.py b/PyRoom/gui.py
@@ -63,6 +63,16 @@ def __init__(self, theme_name):
         theme_file.read(theme_filename)
         self.update(theme_file.items('theme'))
 
+    def __getitem__(self, item):
+        """get default values from our default theme
+
+        this is to handle custom themes from older versions"""
+        try:
+            return dict.__getitem__(self, item)
+        except KeyError:
+            default_theme = Theme('green')
+            return default_theme[item]
+
     def _lookup_theme(self, theme_name):
         """lookup theme_filename for given theme_name