Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11 is not one of the allowed literal values (0, 1, 2) #284

Closed
christoph-morrison opened this issue May 20, 2020 · 0 comments
Closed

11 is not one of the allowed literal values (0, 1, 2) #284

christoph-morrison opened this issue May 20, 2020 · 0 comments
Assignees
@christoph-morrison
Labels
enhancement New feature or request Perl::Critic Issues raised by Perl::Critic waiting for release Is waiting for to be released
Milestone
3.0.8

Comments

@christoph-morrison
Copy link
Collaborator

11 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 642, column 76. Unnamed numeric literals make code less maintainable. (Severity: 2)
@christoph-morrison christoph-morrison added Perl::Critic Issues raised by Perl::Critic enhancement New feature or request labels May 20, 2020
@christoph-morrison christoph-morrison added this to the 3.0.8 milestone May 20, 2020
@christoph-morrison christoph-morrison self-assigned this May 20, 2020
@christoph-morrison christoph-morrison added the waiting for release Is waiting for to be released label May 20, 2020
@christoph-morrison christoph-morrison mentioned this issue May 20, 2020
Merged
christoph-morrison added a commit that referenced this issue May 20, 2020
@christoph-morrison
#282 #283 #284 #285 #286 #287 #288 #289 #290 #291 #292 Refactored mag…
cdebf92 
…ic numbers to named constants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christoph-morrison christoph-morrison

Labels
enhancement New feature or request Perl::Critic Issues raised by Perl::Critic waiting for release Is waiting for to be released
Milestone
3.0.8
Development

No branches or pull requests
1 participant
@christoph-morrison