New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename predicate methods (no `is_` prefix). #24

Merged

jawalonoski merged 1 commit into fhir-crucible:master from Mckesson-cds:rubocop-cleanup-2

Feb 7, 2017

Contributor

olbrich commented Feb 4, 2017

More code cleanup. Just fixing predicate methods.


          rename predicate methods (no is_ prefix).

1f9201c

Member

jawalonoski commented Feb 7, 2017

I prefer the is_ prefix when I'm reading the code... but I'm fine merging this in since you apparently feel so strongly about it.

jawalonoski merged commit 617d5c1 into fhir-crucible:master

Contributor Author

olbrich commented Feb 7, 2017

Thanks! FYI, this is based on the ruby style guide... https://github.com/bbatsov/ruby-style-guide#bool-methods-qmark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet