feat:Adding ability to send back picture of Id document #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xtuytuy
force-pushed
the
add-option-to-send-back-of-image
branch
from
4717c75
to
a41a34b
Compare
included in the phone number field
…to be merged with IDC
cajubelt
reviewed
Jan 20, 2023
cajubelt
reviewed
Jan 20, 2023
jophish
reviewed
Jan 23, 2023
jophish
reviewed
Jan 23, 2023
IdentificationTypeEnum and edited the table of content + some formating
|
@jophish just updated the PR with all your comments, let me know your thoughts. |
jophish
reviewed
Jan 25, 2023
fiatconnect-api.md
Outdated
| @@ -2227,12 +2230,67 @@ A KYC schema containing personal data about a user, as well as documents such as | |||
| }, | |||
| phoneNumber: `string`, | |||
| selfieDocument: `string`, | |||
| identificationDocument: `string` | |||
| identificationDocument: `string` | |||
There was a problem hiding this comment.
nit: indentation (I don't think I can add tab characters to suggestions)
There was a problem hiding this comment.
Should be fixed, the file is not consistent as a whole though, sometime there is use of tab, sometime there is double space:
and
…e tabs / whitespaces
|
in an effort to shorten the cycle time Joe opened his own version of this to address his own comments #92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prevent fraud, most identity cards worldwide include anti-forgery specifications on the back.
As a result, many Know Your Customer (KYC) providers require or allow the submission of the back of the identity card. To accommodate this requirement, we should support the submission of the back of identity cards as an optional field.
It should be noted that not all identity documents, such as passports, require a back image to be submitted.