Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Adding ability to send back picture of Id document (w/ minor changes) #92

Merged
merged 3 commits into from
Jan 30, 2023

Conversation

jophish
Copy link
Contributor

@jophish jophish commented Jan 30, 2023

See #90; this is just a new PR with minor styling/syntax changes applied to expedite the process of getting the content merged. (I tried using git format-patch and git am but got frustrated and gave up 😅)

postalCode?: `string`
},
phoneNumber: `string`,
email?: `string`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jophish email must be required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, thanks

Copy link
Contributor Author

@jophish jophish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

psuedo-approving this since i'm not really the author on this!

@jophish jophish merged commit 34ec6e1 into main Jan 30, 2023
@jophish jophish deleted the jophish/id-back-schema branch January 30, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants