Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #302 - Solve outputs bug #303

Merged
merged 3 commits into from
Dec 30, 2019
Merged

Fixes #302 - Solve outputs bug #303

merged 3 commits into from
Dec 30, 2019

Conversation

AntiD2ta
Copy link
Contributor

Fixes #302

Changes:

  • Returns if call to ScanUnspentOutputs fails when loading the model data.

Does this change need to mentioned in CHANGELOG.md?
no

Requires testing
no

@AntiD2ta
[outputs] refs fibercrypto#302 - Solve bug
d930ba1 
Returns if call to ScanUnspentOutputs fails
@AntiD2ta AntiD2ta added bug Something isn't working stdev wip Work in progress gui Problem with the Graphic User Interface labels Dec 26, 2019
@AntiD2ta AntiD2ta added this to the 0.27.0 milestone Dec 26, 2019
@AntiD2ta AntiD2ta requested a review from olemis December 26, 2019 22:09
@AntiD2ta AntiD2ta self-assigned this Dec 26, 2019
@olemis
[models] refs fibercrypto#302 - Skip addresses with no outputs in Mod…
a0664dd 
…elWallets.loadModel ...

... rather than halting the cycle
olemis
olemis requested changes Dec 29, 2019
View reviewed changes
Copy link
Contributor

@olemis olemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stdevAntiD2ta pls add a test case

@stdevMac stdevMac merged commit 2399d16 into fibercrypto:develop Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemis olemis olemis requested changes

@stdevMac stdevMac stdevMac approved these changes

Assignees

@AntiD2ta AntiD2ta

Labels
bug Something isn't working gui Problem with the Graphic User Interface stdev wip Work in progress
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.

Crash when outputs view opened
3 participants
@AntiD2ta @olemis @stdevMac