Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #298 - Configuration of app's logger #317

Merged
merged 39 commits into from
Jan 25, 2020
Merged

Fixes #298 - Configuration of app's logger #317

merged 39 commits into from
Jan 25, 2020

Conversation

AntiD2ta
Copy link
Contributor

Fixes #298

Changes:

  • Add pipeline for change the level of logs from Settings view
  • Add pipeline for change the output of logs from Settings view

Does this change need to mentioned in CHANGELOG.md?
yes | no

Requires testing
yes

Comments about testing , should you have some

AntiD2ta and others added 22 commits January 3, 2020 19:13
@AntiD2ta
[ui] refs fibercrypto#298 - Add Radio Buttons to select log output de…
f03d126 
…stination and a Combo box to select log level
@AntiD2ta
[config] refs fibercrypto#298 - Add default configuration for log level
0364ad1
@AntiD2ta
[ui] refs fibercrypto#298 - Add config option for log level
0b39a01
@AntiD2ta
[main] [config] refs fibercrypto#298 - Add log level settings
b956f08
@AntiD2ta
[ui] refs fibercrypto#298 - Add TextField for log Level
7fbc7a7 
I would like a ComboBox with fixed options, but I couldn't do it right
@AntiD2ta
Merge branch 'develop' into stdevAntiD2ta_t298_Log_events_to_file
2346a76
@AntiD2ta
[util] refs fibercrypto#298 - Keep references of packages loggers
9cf37c9 
This allows to changes logger properties and propagate this changes across all modules's logger
@mauricio1802 @AntiD2ta
[settings] Add log level as an independent option
9cad3e2
@AntiD2ta
[ui] refs fibercrypto#298 - Change path to log level configuration
a693890
@AntiD2ta
[util] refs fibercrypto#298 - Add function to set log's output to a file
9b97156
@AntiD2ta
[util] refs fibercrypto#298 - Add some changes to logging package
85f0c7e 
Changes:
- Add SetOutput function to set the desired logger's output given a option
- Return error in SetOutputToFile function
@AntiD2ta
[config] refs fibercrypto#298 - Add configuration option for log's ou…
74e7cdd 
…tput

Path: skycoin/log/output
@AntiD2ta
[main] refs fibercrypto#298 - Set log's output correctly given option…
fca2d43 
… in settings
@AntiD2ta
[ui] refs fibercrypto#298 - Add ui to set log's output in Settings
9ea9df3 
This need to be upgraded
@AntiD2ta
[ui] - Remove unnecessary qml log
8f7bc72 
LALALA log
@AntiD2ta
[logging] refs fibercrypto#298 - Create Writer for none option
4ded230 
Writer that write nothing
@AntiD2ta
[logging] refs fibercrypto#298 - Add stderr and none options to SetOu…
8bb88cb 
…tput
@AntiD2ta
[config] refs fibercrypto#298 - Change default value for log's output…
f4215c5 
… to none
@AntiD2ta
[models] refs fibercrypto#298 - Apply changed settings related to log…
f313996 
…s when they are saved
@AntiD2ta
[gitignore] - Ignore .log extensions
c053490
@AntiD2ta
[logging] refs fibercrypto#298 - Refactorize code
a2b05a3 
Remove SetOutput function and add GetOutputWriter function to return the io.Writer that needs to be given to SetOutputTo function
@AntiD2ta
[skycoin] [models] refs fibercrypto#298 - Change output of SkycoinPro…
512ec7a 
…ject's logger

This occurs when the app's logger change its output
@AntiD2ta AntiD2ta added stdev wip Work in progress config App configuration labels Jan 21, 2020
@AntiD2ta AntiD2ta added this to the 0.27.0 milestone Jan 21, 2020
@AntiD2ta AntiD2ta self-assigned this Jan 21, 2020
@AntiD2ta AntiD2ta added this to In progress in FiberCrypto wallet - Iteration 1 via automation Jan 21, 2020
@AntiD2ta AntiD2ta mentioned this pull request Jan 21, 2020
Closed
olemis
olemis requested changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@olemis olemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stdevAntiD2ta more tests need be written

src/models/config.go Outdated Show resolved Hide resolved
src/models/config.go Outdated Show resolved Hide resolved
src/models/config.go Outdated Show resolved Hide resolved
src/models/config.go Outdated Show resolved Hide resolved
src/models/config.go Outdated Show resolved Hide resolved
src/ui/Settings.qml Outdated Show resolved Hide resolved
@olemis
Copy link
Contributor

olemis commented Jan 21, 2020

@stdevAntiD2ta more tests need be written

for coverage to be reported ok

@AntiD2ta AntiD2ta requested a review from olemis January 22, 2020 21:45
@olemis olemis merged commit 91b2ca4 into fibercrypto:develop Jan 25, 2020
FiberCrypto wallet - Iteration 1 automation moved this from In progress to Done Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemis olemis olemis approved these changes

@stdevMac stdevMac Awaiting requested review from stdevMac

Assignees

@AntiD2ta AntiD2ta

Labels
config App configuration stdev wip Work in progress
Projects
FiberCrypto wallet - Iteration 1
  
Done
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.

Log app events to file
3 participants
@AntiD2ta @olemis @mauricio1802