-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved widgets for log's configuration options #318
Comments
Thanks @stdevAntiD2ta I will start with this tomorrow. |
AntiD2ta
added a commit
to simelo/fibercryptowallet
that referenced
this issue
Jan 26, 2020
… Add some logs
AntiD2ta
added a commit
to simelo/fibercryptowallet
that referenced
this issue
Jan 26, 2020
… for log level This function returns a logrus.level from an enum identifier.
AntiD2ta
added a commit
to simelo/fibercryptowallet
that referenced
this issue
Jan 26, 2020
AntiD2ta
added a commit
to simelo/fibercryptowallet
that referenced
this issue
Feb 5, 2020
AntiD2ta
added a commit
to simelo/fibercryptowallet
that referenced
this issue
Feb 5, 2020
…pipeline Changes: - Add a enum for output options - In case that output is `File`, call to GetFileToLog is postponed to when outputFile option is get from the configuration options - Changes permission of file .log created to 0344 (old: 0600)
AntiD2ta
added a commit
to simelo/fibercryptowallet
that referenced
this issue
Feb 5, 2020
… when settings are saved When the output change from stderr to File(for example) the logs are written to the file with a weird format, in the other way, logs aren't written to the console
AntiD2ta
added a commit
to simelo/fibercryptowallet
that referenced
this issue
Feb 5, 2020
…guration options
Already solved here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Currently the log's configuration options are modified in Settings view using TextFields in PR #317 . This is not the best choice because the user can insert wrong options and there is no way of suggest possible options.
Describe the solution you'd like
There is two configuration options for logs.
For Log Level it would be fine a Combo Box with all possible values:
For Log Output it would be fine a set of Radio Buttons with these possible values:
If option
file
is marked, then a dialog box or a hidden TextField should appear to insert the path to file where logs would be writtenAdditional context
This was my initial implementation of the log level Combo Box:
The text was updated successfully, but these errors were encountered: