add unit tests for LookupWallet ref #139

src/coin/skycoin/models/wallet.go

@@ -741,7 +741,11 @@ func NewWalletDirectory(dirPath string) *WalletDirectory {
 type WalletDirectory struct {
 	//Implements WallentEnv interface
 	WalletDir  string
-	wltService *SkycoinLocalWallet
+	wltService core.PersistibleSet
+}
+
+func (wd *WalletDirectory) SetWltService(wltSrv core.PersistibleSet) {
+	wd.wltService = wltSrv
 }
 
 func lookupWallet(env core.WalletEnv, firstAddr string) (core.Wallet, error) {

src/coin/skycoin/models/wallet_test.go

@@ -1,7 +1,10 @@
 package skycoin
 
 import (
+	mocks2 "github.com/fibercrypto/fibercryptowallet/src/coin/mocks"
+	"github.com/fibercrypto/fibercryptowallet/src/errors"
 	"math"
+	"os"
 	"strconv"
 	"testing"
 
@@ -1043,3 +1046,48 @@ func TestSkycoinWalletTypes(t *testing.T) {
 	require.Equal(t, wallet.WalletTypeBip44, wltSet.DefaultWalletType())
 	require.Equal(t, []string{wallet.WalletTypeDeterministic, wallet.WalletTypeBip44}, wltSet.SupportedWalletTypes())
 }
+
+func TestLookupWalletOk(t *testing.T) {
+	// Giving
+	ws := &mocks2.PersistibleSet{}
+	_, kd, err := makeUxOutWithSecret(t)
+	require.NoError(t, err)
+	wallets := makeLocalWalletsFromKeyData(t, []KeyData{*kd})
+	ws.On("ListWallets").Return(NewSkycoinWalletIterator(wallets))
+	we := NewWalletDirectory(os.TempDir())
+	we.SetWltService(ws)
+	addrs := wallets[0].GenAddresses(core.AccountAddress, 0, 1, nil)
+	require.True(t, addrs.Next())
+	addr1 := addrs.Value()
+
+	// When
+	wltFound, err := we.LookupWallet(addr1.String())
+
+	// Then
+	require.NoError(t, err)
+	require.Equal(t, wallets[0], wltFound)
+}
+
+func TestLookupWalletFailAsExpected(t *testing.T) {
+	// Giving
+	ws := &mocks2.PersistibleSet{}
+	_, kd, err := makeUxOutWithSecret(t)
+	require.NoError(t, err)
+	wallets := makeLocalWalletsFromKeyData(t, []KeyData{*kd})
+	ws.On("ListWallets").Return(NewSkycoinWalletIterator(wallets))
+	we := NewWalletDirectory(os.TempDir())
+	we.SetWltService(ws)
+	addrs := wallets[0].GenAddresses(core.AccountAddress, 0, 1, nil)
+	require.True(t, addrs.Next())
+	addr1 := addrs.Value()
+	strAddr := addr1.String()
+	strAddr = strAddr[len(strAddr)/2:] + strAddr[:len(strAddr)/2]
+
+	// When
+	wltFound, err := we.LookupWallet(strAddr)
+
+	// Then
+	require.Error(t, err)
+	require.Equal(t, errors.ErrWltFromAddrNotFound, err)
+	require.Equal(t, nil, wltFound)
+}

src/core/wallet.go

@@ -24,6 +24,11 @@ type WalletSet interface {
 	SupportedWalletTypes() []string
 }
 
+type PersistibleSet interface {
+	WalletSet
+	WalletStorage
+}
+
 // WalletStorage provides access to the underlying wallets data store
 type WalletStorage interface {
 	// Encrypt protects wallet data using cryptography