Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement hardware wallet transaction signing strategy #139

Closed
1 task done
olemis opened this issue Sep 20, 2019 · 0 comments · Fixed by #253
Closed
1 task done

Implement hardware wallet transaction signing strategy #139

olemis opened this issue Sep 20, 2019 · 0 comments · Fixed by #253
Assignees
@olemis @stdevAlDen
Labels
sign_api Altcoin API for signing transactions skyfiber SkyFiber altcoin plugin skywallet SkyWallet hardware wallet stdev wallet-hw Hardware wallet integration wip Work in progress
Projects
FiberCrypto wallet - Iteration 1
Milestone
0.27.0

Comments

@olemis
Copy link
Contributor

olemis commented Sep 20, 2019 •
edited

Feature description

Sign transactions with Skycoin hardware wallet

Is your feature request related to a problem? Please describe.
Signing transactions with hardware wallet is not yet supported.

Describe the solution you'd like
Implement transaction signing using Skycoin hardware wallet go library .

Describe alternatives you've considered
Skycoin hardware wallet daemon service is another way to go , but over-complicates an initial integration . it also adds non trivial complexity and security risks .

Additional context
Requires #138 .

Possible implementation

  • Implement TxnSignStrategy for SkyWallet devices .
@olemis olemis self-assigned this Sep 20, 2019
@olemis olemis added sign_api Altcoin API for signing transactions skyfiber SkyFiber altcoin plugin stdev wallet-hw Hardware wallet integration wip Work in progress labels Sep 20, 2019
@olemis olemis added this to To do in FiberCrypto wallet - Iteration 1 via automation Sep 20, 2019
@olemis olemis added this to the 0.27.0 milestone Sep 20, 2019
@olemis olemis mentioned this issue Sep 20, 2019
Open
2 tasks
@olemis olemis moved this from To do to In progress in FiberCrypto wallet - Iteration 1 Sep 24, 2019
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Oct 9, 2019
@stdevAlDen
vendor packages ref fibercrypto#139
79a2dbc
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Oct 9, 2019
@stdevAlDen
vendor packages ref fibercrypto#139
5cfe6d1
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Oct 9, 2019
@stdevAlDen
vendor packages ref fibercrypto#139
73cac14
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Oct 10, 2019
@stdevAlDen
Merge remote-tracking branch 'origin/olemis_t138_txn_sign' into stdev…
55421e5 
…AlDen_t139_hardware_wallet_signer ref fibercrypto#139
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Oct 14, 2019
@stdevAlDen
ignore github.com/therecipe/qt ref fibercrypto#139
51a6550
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Oct 14, 2019
@stdevAlDen
add hardware wallet singner implementation ref fibercrypto#139
32e545f
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Oct 14, 2019
@stdevAlDen
make device injectable and fix error handling in GetSignerUID ref fib…
469135a 
…ercrypto#139
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Oct 14, 2019
@stdevAlDen
generate mocks from Makefile ref fibercrypto#139
9aebbca
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Oct 14, 2019
@stdevAlDen
Add TestGetSignerUIDShouldBeOk ref fibercrypto#139
cff2f3a
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Oct 14, 2019
@stdevAlDen
Add TestGetSignerUIDShouldFailForUninitializedDevice ref fibercrypto#139
14d3bc0
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Oct 14, 2019
@stdevAlDen
Add TestGetSignerUIDShouldFailOnDeviceError ref fibercrypto#139
c4d7f5f
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Oct 14, 2019
@stdevAlDen
Add TestGetSignerUIDShouldFailForFailResponse ref fibercrypto#139
8b04905
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Oct 14, 2019
@stdevAlDen
Add TestGetSignerUIDShouldFailForInvalidMessageType ref fibercrypto#139
dca02a3
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Oct 14, 2019
@stdevAlDen
fix import in tests ref fibercrypto#139
016d7b3
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Oct 14, 2019
@stdevAlDen
Fix GetSignerDescription, error handling, urnPrefix and i18n ref fibe…
561c867 
…rcrypto#139
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Oct 14, 2019
@stdevAlDen
Add TestGetSignerDescriptionShouldBeOk ref fibercrypto#139
513e7bb
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Oct 14, 2019
@stdevAlDen
Add TestGetSignerDescriptionShouldFailForUninitializedDevice ref fibe…
3a5c02f 
…rcrypto#139
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Oct 14, 2019
@stdevAlDen
Add TestGetSignerDescriptionShouldFailOnDeviceError ref fibercrypto#139
d428c29
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Oct 14, 2019
@stdevAlDen
Add TestGetSignerDescriptionShouldFailForFailResponse ref fibercrypto…
fd0b183 
…#139
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Feb 12, 2020
@stdevAlDen
generate coverage report from skywallet ref fibercrypto#139
faba87c
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Feb 13, 2020
@stdevAlDen
update vendors ref fibercrypto#139
f91fde3
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Feb 14, 2020
@stdevAlDen
get signature as hex value from skycoin API ref fibercrypto#139
80c327c
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Feb 14, 2020
@stdevAlDen
fix find Addr Index From Input
60defd0 
address index for the spend output related for the input is used to find the priv/pub key pair
ref fibercrypto#139
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Feb 14, 2020
@stdevAlDen
Merge remote-tracking branch 'upstream/develop' into stdevAlDen_t139_…
3b3b02f 
…hardware_wallet_signer

Conflicts:
	Gopkg.lock
ref fibercrypto#139
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Feb 14, 2020
@stdevAlDen
update vendors ref fibercrypto#139
6710f44
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Feb 14, 2020
@stdevAlDen
update changes log ref fibercrypto#139
8b22169
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Feb 14, 2020
@stdevAlDen
set the wallet as default signer in the view ref fibercrypto#139
b9ceff6
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Feb 14, 2020
@stdevAlDen
fix: be able to use the wallet it selft on having multiple signers ref …
5be3a38 
…fibercrypto#139
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Feb 14, 2020
@stdevAlDen
fix tests: use a skycoin API client from a mock ref fibercrypto#139
a21d409
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Feb 14, 2020
@stdevAlDen
fix test: load more addresess to make getAddrIndex working when using…
3a67b89 
… GetLoadedAddresses ref fibercrypto#139
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Feb 14, 2020
@stdevAlDen
Refactor
7255f42 
	renamed:    src/contrib/hardware-wallet/device_helper.go -> src/contrib/skywallet/device_helper.go
	renamed:    src/contrib/hardware-wallet/device_interaction.go -> src/contrib/skywallet/device_interaction.go
	renamed:    src/contrib/hardware-wallet/skywallet/mocks/device_driver.go -> src/contrib/skywallet/skywallet/mocks/device_driver.go
	renamed:    src/contrib/hardware-wallet/skywallet/mocks/devicer.go -> src/contrib/skywallet/skywallet/mocks/devicer.go
	renamed:    src/contrib/hardware-wallet/skywallet/sky-wallet.go -> src/contrib/skywallet/skywallet/sky-wallet.go
	renamed:    src/contrib/hardware-wallet/skywallet/sky-wallet_test.go -> src/contrib/skywallet/skywallet/sky-wallet_test.go
	renamed:    src/contrib/hardware-wallet/skywallet/sky_wallet_helper.go -> src/contrib/skywallet/skywallet/sky_wallet_helper.go
	renamed:    src/contrib/hardware-wallet/skywallet/skywallet_device_interaction.go -> src/contrib/skywallet/skywallet/skywallet_device_interaction.go
	renamed:    src/contrib/hardware-wallet/skywallet/skywallet_integration_test.go -> src/contrib/skywallet/skywallet/skywallet_integration_test.go
ref fibercrypto#139
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Feb 14, 2020
@stdevAlDen
Revert "Refactor"
59ca0b8 
This reverts commit 7255f42.
ref fibercrypto#139
@olemis olemis added the skywallet SkyWallet hardware wallet label Feb 27, 2020
olemis added a commit to simelo/fibercryptowallet that referenced this issue Mar 3, 2020
@olemis
[errors] refs fibercrypto#139 - Fix ErrNotImplemented redeclared
4916a2a
olemis added a commit to simelo/fibercryptowallet that referenced this issue Mar 4, 2020
@olemis
[sky] refs fibercrypto#139 - Adjust test comparing params.DataRefresh…
40513b2 
…Timeout vs SkycoinBlockchain.CacheTime
olemis added a commit to simelo/fibercryptowallet that referenced this issue Mar 4, 2020
@olemis
[sky] refs fibercrypto#139 - Correct comparison between params.DataRe…
cd674d6 
…freshTimeout and SkycoinBlockchain.CacheTime
olemis added a commit to simelo/fibercryptowallet that referenced this issue Mar 4, 2020
@olemis
[ci] refs fibercrypto#139 - Remove duplicate declaration of make test…
f405a23 
…-skyhw target
olemis added a commit to simelo/fibercryptowallet that referenced this issue Mar 4, 2020
@olemis
[ci] refs fibercrypto#139 - Increase Skycoin test suite timeout
3c19cd9
olemis added a commit to simelo/fibercryptowallet that referenced this issue Mar 4, 2020
@olemis
[ci] refs fibercrypto#139 - Do not make build prior to make test-skyhw
d52aef3
olemis added a commit to simelo/fibercryptowallet that referenced this issue Mar 4, 2020
@olemis
[contrib] [models] refs fibercrypto#139 - Handle errors after changin…
6e9010a 
…g signature of GetSpentOutput and GetAddress

... still WiP
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Mar 4, 2020
@stdevAlDen
improve error handling in derivationType determination ref fibercrypt…
7dcd440 
…o#139
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Mar 4, 2020
@stdevAlDen
fix mocks generation rule ref fibercrypto#139
7005f40
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Mar 4, 2020
@stdevAlDen
fix number scale in tests ref fibercrypto#139
e51a14f
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Mar 4, 2020
@stdevAlDen
fix rawTxn2Transaction, handle errors ref fibercrypto#139
650034d
FiberCrypto wallet - Iteration 1 automation moved this from In progress to Done Mar 4, 2020
olemis added a commit that referenced this issue Mar 4, 2020
@olemis
Merge pull request #253 from simelo/stdevAlDen_t139_hardware_wallet_s…
44dd804 
…igner

Hardware wallet signer fixes #139
This was referenced Mar 9, 2020
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olemis olemis

@stdevAlDen stdevAlDen

Labels
sign_api Altcoin API for signing transactions skyfiber SkyFiber altcoin plugin skywallet SkyWallet hardware wallet stdev wallet-hw Hardware wallet integration wip Work in progress
Projects
FiberCrypto wallet - Iteration 1
  
Done
Milestone
0.27.0
Development

Successfully merging a pull request may close this issue.

Hardware wallet signer fixes #139 simelo/fibercryptowallet
2 participants
@olemis @stdevAlDen