Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helpers.py:90-95: Use or create clear selenium.WebElement... #323

Closed
0pdd opened this issue Jun 3, 2018 · 2 comments
Closed

helpers.py:90-95: Use or create clear selenium.WebElement... #323

0pdd opened this issue Jun 3, 2018 · 2 comments
Assignees
@ArtemijRodionov
Labels
1 hour typical issue size. It's one pdd hour 3 we can defer this issue. But it'll good to implement it cleanup everything that do project stronger, flexible, reusable report Put it to completed tasks temporary list for business

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jun 3, 2018

The puzzle 300-0d5387ef from #300 has to be resolved:

shopelectro/shopelectro/tests/helpers.py

Lines 90 to 95 in c748051

# @todo #300:60m Use or create clear selenium.WebElement behaviour system.from
# Currently we return element from click method.
# It's not clear design decision. Use or create your own behaviour system.
# Some pipeline like WebElement or custom one.
# Maybe page objects pattern will be helpful:
# http://selenium-python.readthedocs.io/page-objects.html

The puzzle was created by duker33 on 03-Jun-18.

Estimate: 60 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Jun 3, 2018

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Jun 3, 2018
@duker33
#300 Test drone (#301)
c748051 
* #300  Stabilize selenium tests

- Fix tests, fallen by some fast fix
- Review#2 code style fixes
- Fix front static build by drone
- Review#1 minor fixes
- Remove problem assert from test
- Make problem order mail test more strict
- Remove notify webhooks
- Disable cache for price and excel files. Add several shortcuts to makefile
- Fix phone form autoedit error
- Stabilize selenium search tests
- Fix two cart unsafe tests
- Fix Ya.Metric selenium tests
- Move some selenium tests from timeouts to events. Skip `test_tree_*` tests group.
- Try to increase selenium wait value
- Change selenium version on drone
- Fix number of parallel tests
- Fix selenium service config. Fix nodejs service volumes
- Create env var for postgres data dir
- Add drone badge
@0pdd 0pdd mentioned this issue Jun 3, 2018
Closed
@duker33 duker33 added 1 hour typical issue size. It's one pdd hour 3 we can defer this issue. But it'll good to implement it take it any teammate can take this issue and start working with it cleanup everything that do project stronger, flexible, reusable labels Jun 3, 2018
@ArtemijRodionov ArtemijRodionov self-assigned this Jan 12, 2019
@ArtemijRodionov ArtemijRodionov removed the take it any teammate can take this issue and start working with it label Jan 12, 2019
@ArtemijRodionov ArtemijRodionov mentioned this issue Jan 15, 2019
Merged
ArtemijRodionov added a commit that referenced this issue Jan 16, 2019
@ArtemijRodionov
#682 #323 production tests (#688)
9ef7b84 
* Fix LIVESERVER_HOST comment

* Create selenium service for docker-compose

* Create SiteDriver

* Create selenium.{pages,elements}

* Create check_production task for celery

* Create shopelectro.selenium module.

* Create check_purchase

* Self review fixes

* Review fixes

* Applt linter rules
@0pdd 0pdd closed this as completed Jan 16, 2019
@0pdd
Copy link
Collaborator Author

0pdd commented Jan 16, 2019

The puzzle 300-0d5387ef has disappeared from the source code, that's why I closed this issue. //cc @artemiyds2 @duker33

@ArtemijRodionov ArtemijRodionov added the report Put it to completed tasks temporary list for business label Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 hour typical issue size. It's one pdd hour 3 we can defer this issue. But it'll good to implement it cleanup everything that do project stronger, flexible, reusable report Put it to completed tasks temporary list for business
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@duker33 @ArtemijRodionov @0pdd