Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests_views.py:58: Divide the CatalogPage test class into... #338

Closed
0pdd opened this issue Jun 8, 2018 · 3 comments
Closed

tests_views.py:58: Divide the CatalogPage test class into... #338

0pdd opened this issue Jun 8, 2018 · 3 comments
Labels
3 we can defer this issue. But it'll good to implement it 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable easy new teammates can start with such issues to become familiar with project invalid

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jun 8, 2018

The puzzle 302-31c4df63 from #302 has to be resolved:

shopelectro/shopelectro/tests/tests_views.py

Line 58 in 96e1474

@todo #302 Divide the CatalogPage test class into parts related to the features.

The puzzle was created by Artemiy on 08-Jun-18.

Estimate: 0 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Jun 8, 2018

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Jun 8, 2018
@ArtemijRodionov
Create a pagination object for view. Create todos for the issue (#325)
96e1474 
Update todo

Create tests for pagination

Fix todo

Review fixes

Review fixes
@0pdd 0pdd mentioned this issue Jun 8, 2018
Closed
@duker33 duker33 added 30 mins middle-sized issue. Usually a part of feature or a fix 3 we can defer this issue. But it'll good to implement it take it any teammate can take this issue and start working with it easy new teammates can start with such issues to become familiar with project cleanup everything that do project stronger, flexible, reusable labels Jun 9, 2018
@0pdd
Copy link
Collaborator Author

0pdd commented Jun 15, 2018

The puzzle 302-31c4df63 has disappeared from the source code, that's why I closed this issue. //cc @artemiyds2 @duker33

@0pdd 0pdd closed this as completed Jun 15, 2018
0pdd referenced this issue Jun 15, 2018
@duker33
#fix Fix pdd puzzle (#349)
7a0860e
@duker33 duker33 added invalid and removed take it any teammate can take this issue and start working with it labels Jun 15, 2018
@duker33
Copy link
Contributor

duker33 commented Jun 15, 2018

double of #350

duker33 added a commit that referenced this issue Jun 11, 2019
@duker33
#338 Create test for tags disjunction
48f9318
duker33 added a commit that referenced this issue Jun 11, 2019
@duker33
#872 Rm images copying logic from fixtures generating (#873)
c878c5a 
* #872  Rm images copying logic

* #338  Create test for tags disjunction

* #872  Fix tags selenium tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 we can defer this issue. But it'll good to implement it 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable easy new teammates can start with such issues to become familiar with project invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duker33 @0pdd