Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests_views.py:204-207: Implement test case for... #339

Closed
0pdd opened this issue Jun 8, 2018 · 7 comments
Closed

tests_views.py:204-207: Implement test case for... #339

0pdd opened this issue Jun 8, 2018 · 7 comments
Labels
2 performer can implement issue at his closest convenient time 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable easy new teammates can start with such issues to become familiar with project feature issue provides some new functionality for project user invalid

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jun 8, 2018

The puzzle 302-ab23fc9d from #302 has to be resolved:

shopelectro/shopelectro/tests/tests_views.py

Lines 204 to 207 in 96e1474

@todo #302:30m Implement test case for pagination logic.
Products number changes in depend on page number.
If step=24 and page number=2, then products quantity is 48.
If step=24 and page number=2 and total products quantity is 40, then products quantity is 40.

The puzzle was created by Artemiy on 08-Jun-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Jun 8, 2018

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Jun 8, 2018
@ArtemijRodionov
Create a pagination object for view. Create todos for the issue (#325)
96e1474 
Update todo

Create tests for pagination

Fix todo

Review fixes

Review fixes
@0pdd 0pdd mentioned this issue Jun 8, 2018
Closed
@duker33 duker33 added 30 mins middle-sized issue. Usually a part of feature or a fix 2 performer can implement issue at his closest convenient time take it any teammate can take this issue and start working with it cleanup everything that do project stronger, flexible, reusable easy new teammates can start with such issues to become familiar with project labels Jun 9, 2018
@0pdd
Copy link
Collaborator Author

0pdd commented Jun 15, 2018

The puzzle 302-ab23fc9d has disappeared from the source code, that's why I closed this issue. //cc @artemiyds2 @duker33

@0pdd 0pdd closed this as completed Jun 15, 2018
0pdd referenced this issue Jun 15, 2018
@duker33
#fix Fix pdd puzzle (#349)
7a0860e
@duker33 duker33 added invalid and removed take it any teammate can take this issue and start working with it labels Jun 15, 2018
@duker33
Copy link
Contributor

duker33 commented Jun 15, 2018

double of #351

@liza-andreeva liza-andreeva mentioned this issue Jun 17, 2018
Closed
@duker33
Copy link
Contributor

duker33 commented Jun 18, 2018

If step=24 and page number=2 and total products quantity is 40, then products quantity is 40.

@artemiy312 , pagination should work in another manner. Page 2 should not contain products from page 1.
In this case page2 should contain 40-24 = 16 products. Let's put 16 instead of 40 for the second case of tests. And fix code to make this requirement working

@ArtemijRodionov
Copy link
Contributor

ArtemijRodionov commented Jun 18, 2018 •
edited

@duker33 Sorry, it is a unclear description. I meant here, that we need to test a total number of already showed products.

default

For this picture it is 96 (page 2)

@liza-andreeva
Copy link
Contributor

В итоге нужно проверить 48 и 96?
Если да, то в #364 уже такая логика.

@duker33 duker33 mentioned this issue Jun 21, 2018
Closed
@duker33
Copy link
Contributor

duker33 commented Jun 21, 2018

@liza-andreeva , @artemiy312 , let's more discussion to #351

@duker33 duker33 mentioned this issue Jun 21, 2018
Open
@duker33 duker33 added the feature issue provides some new functionality for project user label Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 performer can implement issue at his closest convenient time 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable easy new teammates can start with such issues to become familiar with project feature issue provides some new functionality for project user invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@duker33 @ArtemijRodionov @0pdd @liza-andreeva