Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests_views.py:202-205: Implement test case for... #351

Open
0pdd opened this issue Jun 15, 2018 · 7 comments
Open

tests_views.py:202-205: Implement test case for... #351

0pdd opened this issue Jun 15, 2018 · 7 comments
Labels
3 we can defer this issue. But it'll good to implement it 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable easy new teammates can start with such issues to become familiar with project take it any teammate can take this issue and start working with it

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jun 15, 2018

The puzzle 302-fbbfb65a from #302 has to be resolved:

shopelectro/shopelectro/tests/tests_views.py

Lines 202 to 205 in 7a0860e

@todo #302:30m Implement test case for pagination logic.
Products number changes in depend on page number.
If step=24 and page number=2, then products quantity is 48.
If step=24 and page number=2 and total products quantity is 40, then products quantity is 40. # Ignore PycodestyleBear (E501)

The puzzle was created by duker33 on 15-Jun-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Jun 15, 2018

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Jun 15, 2018
@duker33
#fix Fix pdd puzzle (#349)
7a0860e
@0pdd 0pdd mentioned this issue Jun 15, 2018
Closed
@duker33 duker33 added 30 mins middle-sized issue. Usually a part of feature or a fix 3 we can defer this issue. But it'll good to implement it take it any teammate can take this issue and start working with it easy new teammates can start with such issues to become familiar with project cleanup everything that do project stronger, flexible, reusable labels Jun 15, 2018
@duker33 duker33 mentioned this issue Jun 15, 2018
Closed
@liza-andreeva liza-andreeva mentioned this issue Jun 21, 2018
Closed
@duker33
Copy link
Contributor

duker33 commented Jun 21, 2018

answer on Liza's comment:
#339 (comment)

@liza-andreeva , @artemiy312 , let's define terms. Artemiy, this task about pagination or watch_more.
See more about this terms here: fidals/refarm-site#139

@duker33 duker33 added discuss issue needs to finish discussion before start working and removed take it any teammate can take this issue and start working with it labels Jun 21, 2018
@ArtemijRodionov
Copy link
Contributor

@duker33 This task about pagination as I said in previous comment

@duker33
Copy link
Contributor

duker33 commented Jun 22, 2018

@artemiy312 , this screen is from watch_more feature.
Pagination should contain no visible elements count. Pagination should be totally invisible for user.

https://user-images.githubusercontent.com/13870342/41535643-c1dae9ca-730b-11e8-841d-92496e866e9d.png

@duker33
Copy link
Contributor

duker33 commented Jun 22, 2018

So, we clarified with pagination, let's clarify with requirements.
@liza-andreeva , you should implement this test case instead of the second one written in pdd task body
#339 (comment)

@duker33 duker33 removed the discuss issue needs to finish discussion before start working label Jun 22, 2018
@duker33 duker33 added the discuss issue needs to finish discussion before start working label Jun 24, 2018
@duker33
Copy link
Contributor

duker33 commented Jun 24, 2018

@liza-andreeva closed related PR. So, refused task may be

@duker33
Copy link
Contributor

duker33 commented Jul 2, 2018

refused, y. She suggested in direct chat

@duker33 duker33 removed the discuss issue needs to finish discussion before start working label Jul 2, 2018
@duker33 duker33 added the take it any teammate can take this issue and start working with it label Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 we can defer this issue. But it'll good to implement it 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable easy new teammates can start with such issues to become familiar with project take it any teammate can take this issue and start working with it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@duker33 @ArtemijRodionov @0pdd @liza-andreeva