Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

category_products.html:5: Implement pagination buttons... #340

Closed
0pdd opened this issue Jun 8, 2018 · 3 comments
Closed

category_products.html:5: Implement pagination buttons... #340

0pdd opened this issue Jun 8, 2018 · 3 comments
Assignees
@ArtemijRodionov
Labels
1 hour typical issue size. It's one pdd hour 1 burning issue feature issue provides some new functionality for project user from PO from product owner. It's hellxi report Put it to completed tasks temporary list for business

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jun 8, 2018

The puzzle 302-bdb9bbef from #302 has to be resolved:

shopelectro/templates/catalog/category_products.html

Line 5 in 96e1474

{% comment %} @todo #302:60m Implement pagination buttons for seo purposes.

The puzzle was created by Artemiy on 08-Jun-18.

Estimate: 60 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Jun 8, 2018

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Jun 8, 2018
@ArtemijRodionov
Create a pagination object for view. Create todos for the issue (#325)
96e1474 
Update todo

Create tests for pagination

Fix todo

Review fixes

Review fixes
@0pdd 0pdd mentioned this issue Jun 8, 2018
Closed
@duker33 duker33 added 1 hour typical issue size. It's one pdd hour 1 burning issue from PO from product owner. It's hellxi take it any teammate can take this issue and start working with it labels Jun 9, 2018
@ArtemijRodionov ArtemijRodionov self-assigned this Jun 13, 2018
@ArtemijRodionov ArtemijRodionov removed the take it any teammate can take this issue and start working with it label Jun 13, 2018
@ArtemijRodionov
Copy link
Contributor

@duker33 , should hidden buttons either reload (by link) or update (by ajax) the state of a category page?

@duker33
Copy link
Contributor

duker33 commented Jun 15, 2018

@artemiy312 , page full updating will be enough. But choose the most convenient way for realization.

The main requirement here is to load right products set by direct link /my_prod/?page_num=3

@ArtemijRodionov ArtemijRodionov mentioned this issue Jul 3, 2018
Merged
ArtemijRodionov added a commit that referenced this issue Jul 5, 2018
@ArtemijRodionov
#340 Create pagination buttons and canonical links. (#395)
bf13b88 
* Create pagination buttons and canonical links.

* Add hidden class to pagination block

* Review fixes

* Apply linter rules
@ArtemijRodionov ArtemijRodionov added the report Put it to completed tasks temporary list for business label Jul 5, 2018
@duker33 duker33 added the feature issue provides some new functionality for project user label Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 hour typical issue size. It's one pdd hour 1 burning issue feature issue provides some new functionality for project user from PO from product owner. It's hellxi report Put it to completed tasks temporary list for business
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@duker33 @ArtemijRodionov @0pdd