Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_db.py:70-72: Set db name in test_db command. stb2... #404

Closed
0pdd opened this issue Jul 6, 2018 · 3 comments
Closed

test_db.py:70-72: Set db name in test_db command. stb2... #404

0pdd opened this issue Jul 6, 2018 · 3 comments
Assignees
@duker33
Labels
1 hour typical issue size. It's one pdd hour 3 we can defer this issue. But it'll good to implement it cleanup everything that do project stronger, flexible, reusable

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jul 6, 2018

The puzzle 389-3679238e from #389 has to be resolved:

shopelectro/shopelectro/management/commands/test_db.py

Lines 70 to 72 in f9866fd

# @todo #389:60m Set db name in `test_db` command. stb2
# Set name instead of asserting.
# You also should create/drop it with postgres driver.

The puzzle was created by duker33 on 06-Jul-18.

Estimate: 60 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Jul 6, 2018

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Jul 6, 2018
@duker33
#389 Save media (#390)
f9866fd 
- Save media from `test_db` command
- Return vnc to selenium service
- Fix pdd typo
- Fix working with file
- Review#3. Rm redundant file open
@0pdd 0pdd mentioned this issue Jul 6, 2018
Closed
@duker33 duker33 added 1 hour typical issue size. It's one pdd hour 3 we can defer this issue. But it'll good to implement it take it any teammate can take this issue and start working with it cleanup everything that do project stronger, flexible, reusable labels Jul 6, 2018
@duker33
Copy link
Contributor

duker33 commented Dec 26, 2018

refarm too

@duker33
Copy link
Contributor

duker33 commented Mar 24, 2019

that's how django test runner do this:

# django.db.backends.base.creation.BaseDatabaseCreation#create_test_db

        settings.DATABASES[self.connection.alias]["NAME"] = test_database_name
        self.connection.settings_dict["NAME"] = test_database_name

@duker33 duker33 self-assigned this Mar 24, 2019
@duker33 duker33 removed the take it any teammate can take this issue and start working with it label Mar 24, 2019
duker33 added a commit that referenced this issue Apr 3, 2019
@duker33
#404 Draft for temp db
99e88f0
duker33 added a commit that referenced this issue Apr 3, 2019
@duker33
#404 Create make rule for temp db
7763199
This was referenced Apr 3, 2019
Merged
Merged
duker33 added a commit that referenced this issue Apr 4, 2019
@duker33
#404 Create make rule for temp db (#804)
06ecddd 
* #404  Create make rule for temp db

* se#404  Review#1 fix assert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duker33 duker33

Labels
1 hour typical issue size. It's one pdd hour 3 we can defer this issue. But it'll good to implement it cleanup everything that do project stronger, flexible, reusable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duker33 @0pdd