Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catalog.py:57-60: Render 404, that is recommending... #444

Closed
0pdd opened this issue Jul 24, 2018 · 4 comments
Closed

catalog.py:57-60: Render 404, that is recommending... #444

0pdd opened this issue Jul 24, 2018 · 4 comments
Assignees
@duker33
Labels
1 hour typical issue size. It's one pdd hour 1 burning issue easy new teammates can start with such issues to become familiar with project feature issue provides some new functionality for project user from PO from product owner. It's hellxi report Put it to completed tasks temporary list for business

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jul 24, 2018

The puzzle 273-9b2b9d3f from #273 has to be resolved:

shopelectro/shopelectro/views/catalog.py

Lines 57 to 60 in 36a9dd5

# @todo #273 Render 404, that is recommending products for a deleted product.
# 1. Find a product with page__is_active=False
# 2. If the product exists then render 404 with products of its category
# See the parent issue for details.

The puzzle was created by Artemiy on 24-Jul-18.

Estimate: 0 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Jul 24, 2018

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Jul 24, 2018
@ArtemijRodionov
#273 Do not remove products (#443)
36a9dd5 
* Remove ProductPage.objects.delete(...) in favor of ProductPage.objects.update(is_active=True). Add is_active=True to model's filters. Create todo

* Self-review fixes

* Review fixes

* Fix typo

* Apply coala rules
@0pdd 0pdd mentioned this issue Jul 24, 2018
Closed
@duker33 duker33 added feature issue provides some new functionality for project user 1 hour typical issue size. It's one pdd hour 1 burning issue from PO from product owner. It's hellxi take it any teammate can take this issue and start working with it easy new teammates can start with such issues to become familiar with project labels Jul 25, 2018
@duker33 duker33 removed the take it any teammate can take this issue and start working with it label Aug 1, 2018
@duker33 duker33 self-assigned this Aug 1, 2018
duker33 added a commit that referenced this issue Aug 1, 2018
@duker33
#444  Render list of related products at 404 page
8a82161 
Signed-off-by: duker33 <duker33@gmail.com>
duker33 added a commit that referenced this issue Aug 1, 2018
@duker33
#444  Test products list on 404 page
8bd4fba 
Signed-off-by: duker33 <duker33@gmail.com>
duker33 added a commit that referenced this issue Aug 1, 2018
@duker33
#444  Cleanup arch for new code
5544410 
Signed-off-by: duker33 <duker33@gmail.com>
@duker33 duker33 mentioned this issue Aug 1, 2018
Merged
duker33 added a commit that referenced this issue Aug 1, 2018
@duker33
#444  Review#1 fixes. Collapse some code and fix products offsetting
a3127c7 
Signed-off-by: duker33 <duker33@gmail.com>
duker33 added a commit that referenced this issue Aug 2, 2018
@duker33
#444 Render siblings on 404 product page (#468)
4db19ac 
* #444  Render list of related products at 404 page

* #444  Test products list on 404 page

* #444  Cleanup arch for new code

* #444  Review#1 fixes. Collapse some code and fix products offsetting
@0pdd 0pdd mentioned this issue Aug 2, 2018
Closed
@0pdd
Copy link
Collaborator Author

0pdd commented Aug 2, 2018

@0pdd the puzzle #470 is still not solved.

@duker33 duker33 added the report Put it to completed tasks temporary list for business label Aug 2, 2018
@0pdd
Copy link
Collaborator Author

0pdd commented Aug 6, 2018

@0pdd the puzzle #481 is still not solved; solved: #470.

@0pdd
Copy link
Collaborator Author

0pdd commented Aug 17, 2018

@0pdd all 2 puzzles are solved here: #470, #481.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duker33 duker33

Labels
1 hour typical issue size. It's one pdd hour 1 burning issue easy new teammates can start with such issues to become familiar with project feature issue provides some new functionality for project user from PO from product owner. It's hellxi report Put it to completed tasks temporary list for business
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duker33 @0pdd