Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests_selenium.py:679: Hide all form processing methods... #498

Closed
0pdd opened this issue Aug 9, 2018 · 2 comments
Closed

tests_selenium.py:679: Hide all form processing methods... #498

0pdd opened this issue Aug 9, 2018 · 2 comments
Assignees
@ArtemijRodionov
Labels
3 we can defer this issue. But it'll good to implement it 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable easy new teammates can start with such issues to become familiar with project report Put it to completed tasks temporary list for business

Comments

@0pdd
Copy link
Collaborator

0pdd commented Aug 9, 2018

The puzzle 473-40a31b12 from #473 has to be resolved:

shopelectro/shopelectro/tests/tests_selenium.py

Line 679 in abd13f0

# @todo #473:30m Hide all form processing methods to a separated class.

The puzzle was created by duker33 on 09-Aug-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Aug 9, 2018

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Aug 9, 2018
@duker33
#489  Test yandex kassa form selection (#491)
abd13f0 
* #489  Test yandex kassa form selection

* #489  Fix ya kassa processing code and test. Describe failed test case

* #489  Ignore code doubling in expected failed list

* #489  Review#1, fix timeout value

* #489  Review#2, add missed timeout for order submit
@0pdd 0pdd mentioned this issue Aug 9, 2018
Closed
@duker33 duker33 added 30 mins middle-sized issue. Usually a part of feature or a fix 3 we can defer this issue. But it'll good to implement it take it any teammate can take this issue and start working with it easy new teammates can start with such issues to become familiar with project cleanup everything that do project stronger, flexible, reusable labels Aug 9, 2018
@ArtemijRodionov ArtemijRodionov self-assigned this Jan 17, 2019
@ArtemijRodionov ArtemijRodionov removed the take it any teammate can take this issue and start working with it label Jan 17, 2019
@ArtemijRodionov ArtemijRodionov mentioned this issue Jan 17, 2019
Merged
ArtemijRodionov added a commit that referenced this issue Jan 20, 2019
@ArtemijRodionov
#690 #498 #497 Make the check_purchase work (#695)
ce492b1 
* Fix current implementation of selenium classes

* Create Input element class for selenium

* Implement fill_cotacts and make_order methods of OrderPage class

* Self-review fixes

* Create PaymentOptions enum

* Create Button class, implement OrderPage.select_payment_type

* Remove todo about payment_types

* Apply linter rules

* Self-review fixes

* Move PaymentOptions to shopelectro.models

* Fix a typo

* Apply linter rules

* Provide the comment for EnumMeta class.

* Remove excess import from base.py

* Fix typo

* Apply linter rules
@0pdd
Copy link
Collaborator Author

0pdd commented Jan 20, 2019

The puzzle 473-40a31b12 has disappeared from the source code, that's why I closed this issue. //cc @artemiyds2 @duker33

@0pdd 0pdd closed this as completed Jan 20, 2019
@ArtemijRodionov ArtemijRodionov added the report Put it to completed tasks temporary list for business label Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
3 we can defer this issue. But it'll good to implement it 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable easy new teammates can start with such issues to become familiar with project report Put it to completed tasks temporary list for business
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@duker33 @ArtemijRodionov @0pdd