Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracking.es6:30-33: Send purchase event to YA and GA... #524

Closed
0pdd opened this issue Aug 17, 2018 · 1 comment
Closed

tracking.es6:30-33: Send purchase event to YA and GA... #524

0pdd opened this issue Aug 17, 2018 · 1 comment
Assignees
@ArtemijRodionov
Labels
1 hour typical issue size. It's one pdd hour 1 burning issue from PO from product owner. It's hellxi front markup or work with js report Put it to completed tasks temporary list for business Ya eCommerce feature

Comments

@0pdd
Copy link
Collaborator

0pdd commented Aug 17, 2018

The puzzle 504-30170dc3 from #504 has to be resolved:

shopelectro/front/js/shared/tracking.es6

Lines 30 to 33 in 4e607fb

// @todo #504:60m Send `purchase` event to YA and GA after a success purchase.
// This will allow us to send order's id. Currently we send the event after
// submitting of the purchase button with the dummy order's id.
// See the parent issue for a detail.

The puzzle was created by Artemiy on 17-Aug-18.

Estimate: 60 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Aug 17, 2018

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Aug 17, 2018
@ArtemijRodionov
#504 Extend sending info about products to YA and GA systems (#520)
4e607fb 
* Extend sending info about products to YA and GA systems

Self-review fixes

* Create todo for a product's brand

* Create todo for html element's properties

* Apply linter rules
@0pdd 0pdd mentioned this issue Aug 17, 2018
Closed
@ArtemijRodionov ArtemijRodionov added 1 hour typical issue size. It's one pdd hour 1 burning issue from PO from product owner. It's hellxi take it any teammate can take this issue and start working with it labels Aug 17, 2018
@duker33 duker33 added front markup or work with js Ya eCommerce feature labels Aug 18, 2018
@ArtemijRodionov ArtemijRodionov self-assigned this Aug 21, 2018
@ArtemijRodionov ArtemijRodionov removed the take it any teammate can take this issue and start working with it label Aug 21, 2018
@ArtemijRodionov ArtemijRodionov mentioned this issue Aug 21, 2018
Merged
ArtemijRodionov added a commit that referenced this issue Aug 22, 2018
@ArtemijRodionov
#524 jsecommerce purchase (#532)
d5c1803 
* Add order's data to success.html

* Create publishPurchase for success.html. Remove old purchase publishing

* Self-review fixes

* Apply linter rules
@ArtemijRodionov ArtemijRodionov added the report Put it to completed tasks temporary list for business label Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 hour typical issue size. It's one pdd hour 1 burning issue from PO from product owner. It's hellxi front markup or work with js report Put it to completed tasks temporary list for business Ya eCommerce feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@duker33 @ArtemijRodionov @0pdd