Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.drone.yml:127-131: Fill drone-sided app with data. Do... #534

Closed
0pdd opened this issue Aug 22, 2018 · 10 comments
Closed

.drone.yml:127-131: Fill drone-sided app with data. Do... #534

0pdd opened this issue Aug 22, 2018 · 10 comments
Assignees
@ArtemijRodionov
Labels
2 hours some big and monolith issue with hard decisions, discussions or bug with strong research 2 performer can implement issue at his closest convenient time cleanup everything that do project stronger, flexible, reusable devops work with service options with code or with configs report Put it to completed tasks temporary list for business

Comments

@0pdd
Copy link
Collaborator

0pdd commented Aug 22, 2018

The puzzle 517-a10609a6 from #517 has to be resolved:

shopelectro/.drone.yml

Lines 127 to 131 in ee7eda0

# @todo #517:60m Fill drone-sided app with data.
# Do migrate and fixtures load.
# Currently we faced with issues here:
# https://ci.fidals.com/fidals/shopelectro/721/3
# Then try to resurrect health check.

The puzzle was created by duker33 on 22-Aug-18.

Estimate: 60 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Aug 22, 2018

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Aug 22, 2018
@duker33
#517 Come around of droned docker volumes issue (#530)
ee7eda0 
* #517  Come around of droned docker volumes issue

* #517  Cleanup code

* #517  Cleanup code for merge to master

* #517  Review#1 minor fixes
This was referenced Aug 22, 2018
Closed
Closed
Closed
@duker33 duker33 added 1 hour typical issue size. It's one pdd hour 2 performer can implement issue at his closest convenient time take it any teammate can take this issue and start working with it cleanup everything that do project stronger, flexible, reusable devops work with service options with code or with configs labels Aug 22, 2018
@ArtemijRodionov ArtemijRodionov self-assigned this Aug 22, 2018
@ArtemijRodionov ArtemijRodionov removed the take it any teammate can take this issue and start working with it label Aug 22, 2018
@ArtemijRodionov ArtemijRodionov mentioned this issue Aug 22, 2018
Merged
@ArtemijRodionov
Copy link
Contributor

Seems #517 is unresolved, because docker-compose up -d is still failed

@ArtemijRodionov
Copy link
Contributor

We have faced with another one issue, postgres does not work and it seems because of running docker instance in docker.

@duker33
Copy link
Contributor

duker33 commented Aug 23, 2018

Seems #517 is unresolved, because docker-compose up -d is still failed

@artemiy312 , it worked before merge: https://ci.fidals.com/fidals/shopelectro/732
DJANGO_SETTINGS_MODULE=shopelectro.settings.drone for app-drone service should resolve it.
You resolved it already, as i see.

We have faced with another one issue, postgres does not work and it seems because of running docker instance in docker.

@artemiy312 , just comment volumes in postgres service for a while. It's because of them, i think

@ArtemijRodionov
Copy link
Contributor

ArtemijRodionov commented Aug 23, 2018 •
edited

@duker33 Let's clarify, what kind of problem docker-up pipeline will solve for us? Seems we already satisfy requirements of a parent issue, because we already build and use docker images for test, isn't it?

But if we want also to test working of docker-compose.yml, then drone can not help us with it, because we have to create mock configs for it, these do not look helpful
The best way to do it, as I believe, will be deploying of stage with new coming changes after merging of a PR or new release.

drone would help with such deploys

What do you think?

@ArtemijRodionov ArtemijRodionov added the discuss issue needs to finish discussion before start working label Aug 23, 2018
@duker33
Copy link
Contributor

duker33 commented Aug 24, 2018

after merging of a PR or new release

@artemiy312 , it's too late to test code diff, i afraid. But it's better than nothing.
Let's do this. New stage task will be blocked by fidals/stroyprombeton#232

@duker33 duker33 removed the discuss issue needs to finish discussion before start working label Aug 24, 2018
@duker33
Copy link
Contributor

duker33 commented Sep 7, 2018

@artemiy312 , create plz pdd sub-issues and close it

@ArtemijRodionov ArtemijRodionov added 2 hours some big and monolith issue with hard decisions, discussions or bug with strong research and removed 1 hour typical issue size. It's one pdd hour labels Sep 23, 2018
@ArtemijRodionov
Copy link
Contributor

I changed the estimate, because I am going to resolve an issue with the order of container startups

ArtemijRodionov added a commit that referenced this issue Sep 23, 2018
@ArtemijRodionov
#534 Fill the CI's docker-up pipe with data (#536)
b15dcf0 
* Create wait-for.sh. Fill the db for docker-up pipeline.

* Add copyright notice to wait-for
@0pdd 0pdd mentioned this issue Sep 23, 2018
Closed
@0pdd
Copy link
Collaborator Author

0pdd commented Sep 23, 2018

@0pdd the puzzle #587 is still not solved.

@duker33 duker33 added the report Put it to completed tasks temporary list for business label Sep 24, 2018
@0pdd
Copy link
Collaborator Author

0pdd commented Sep 24, 2018

@0pdd the only puzzle #587 is solved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
2 hours some big and monolith issue with hard decisions, discussions or bug with strong research 2 performer can implement issue at his closest convenient time cleanup everything that do project stronger, flexible, reusable devops work with service options with code or with configs report Put it to completed tasks temporary list for business
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@duker33 @ArtemijRodionov @0pdd