Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests_views.py:253-254: Create test(s) for numbered... #555

Closed
0pdd opened this issue Aug 29, 2018 · 2 comments
Closed

tests_views.py:253-254: Create test(s) for numbered... #555

0pdd opened this issue Aug 29, 2018 · 2 comments
Assignees
@ArtemijRodionov
Labels
2 performer can implement issue at his closest convenient time 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable report Put it to completed tasks temporary list for business Tags STB's feature

Comments

@0pdd
Copy link
Collaborator

0pdd commented Aug 29, 2018

The puzzle 539-97439133 from #539 has to be resolved:

shopelectro/shopelectro/tests/tests_views.py

Lines 253 to 254 in f6ab9f0

# @todo #539:30m Create test(s) for numbered pagination.
# Currently we test only a prev/next page feature.

The puzzle was created by Artemiy on 29-Aug-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Aug 29, 2018

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Aug 29, 2018
@ArtemijRodionov
#539 pagination buttons (#546)
f6ab9f0 
* Create PaginatedCatalog class

Update templates

Review fixes

Undo js-catalog-pagination back

* Apply linter rules
@0pdd 0pdd mentioned this issue Aug 29, 2018
Closed
@duker33 duker33 added 30 mins middle-sized issue. Usually a part of feature or a fix 2 performer can implement issue at his closest convenient time take it any teammate can take this issue and start working with it cleanup everything that do project stronger, flexible, reusable Tags STB's feature labels Aug 30, 2018
@duker33
Copy link
Contributor

duker33 commented Aug 30, 2018

it's required for Tags

@ArtemijRodionov ArtemijRodionov self-assigned this Aug 30, 2018
@ArtemijRodionov ArtemijRodionov removed the take it any teammate can take this issue and start working with it label Aug 30, 2018
@ArtemijRodionov ArtemijRodionov mentioned this issue Aug 31, 2018
Merged
ArtemijRodionov added a commit that referenced this issue Sep 1, 2018
@ArtemijRodionov
#555 Create test_numbered_pagination_links (#559)
f2ed402 
* Create test_numbered_pagination_links

* Review fixes
@ArtemijRodionov ArtemijRodionov added the report Put it to completed tasks temporary list for business label Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
2 performer can implement issue at his closest convenient time 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable report Put it to completed tasks temporary list for business Tags STB's feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@duker33 @ArtemijRodionov @0pdd